Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error data.room #65

Open
Vitalicus opened this issue Feb 23, 2022 · 6 comments
Open

Error data.room #65

Vitalicus opened this issue Feb 23, 2022 · 6 comments

Comments

@Vitalicus
Copy link

First run is ok. On reload script stop working. (Ubuntu. Chrome)

if ( socket.adapter.rooms[data.room].length > 1 ) {
                                             ^
TypeError: Cannot read properties of undefined (reading 'length')
@amirjaufeeraully
Copy link

did you fix it???

@Vitalicus
Copy link
Author

no :(

@KFRANCMM
Copy link
Contributor

Hello! If you upgraded the version of socket.io you need to replace that line of code

if ( socket.adapter.rooms.has(data.room) === true )

Pull request #68

@amirjaufeeraully
Copy link

Hey, but do you have any idea how to make the application run on private IPs or public IPs? It only runs on Localhost!

@KFRANCMM
Copy link
Contributor

Hey, but do you have any idea how to make the application run on private IPs or public IPs? It only runs on Localhost!

This is due to a security restriction of the browsers, to access devices such as the camera and microphone. HTTPS and TLS/SSL certificates are required. If you want to run the application on a private IP segment, you could try to use self-signed certificates.

Example self-signed certificates:
https://flaviocopes.com/express-https-self-signed-certificate/

@mohsenkhalafi
Copy link

Hey, but do you have any idea how to make the application run on private IPs or public IPs? It only runs on Localhost!

This is due to a security restriction of the browsers, to access devices such as the camera and microphone. HTTPS and TLS/SSL certificates are required. If you want to run the application on a private IP segment, you could try to use self-signed certificates.

Example self-signed certificates: https://flaviocopes.com/express-https-self-signed-certificate/

Hey..could you convert this source to https in app.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants