Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated createComponent functions should copy annotations to actualized code #72

Open
ZacSweers opened this issue Nov 10, 2024 · 0 comments
Open

Generated createComponent functions should copy annotations to actualized code #72

ZacSweers opened this issue Nov 10, 2024 · 0 comments
Assignees
@vRallev
Labels
bug Something isn't working

Comments

@ZacSweers
Copy link
Contributor

Currently they don't which results in compiler warnings and breaks the ability to use allWarningsAsErrors

> Task :compileKotlinIosX64
w: file:///Users/zacsweers/dev/android/personal/FieldSpottr/build/generated/ksp/iosX64/iosX64Main/kotlin/dev/zacsweers/fieldspottr/di/FSComponent.iosCreateComponent.kt:5:1 Annotation `@CreateComponent` is missing on actual declaration.
All annotations from expect `dev.zacsweers.fieldspottr.di.createComponent` must be present with the same arguments on actual `dev.zacsweers.fieldspottr.di.createComponent`, otherwise they might behave incorrectly.
@vRallev vRallev added the bug Something isn't working label Nov 11, 2024
vRallev added a commit that referenced this issue Nov 15, 2024
@vRallev
Copy required annotations to generated code
73b18ba 
Copy all annotations from `expect fun` functions annotated with `@CreateComponent` to the generated `actual fun` functions to avoid a Kotlin compiler warning.

Fixes #72
@vRallev vRallev mentioned this issue Nov 15, 2024
Open
vRallev added a commit that referenced this issue Nov 15, 2024
@vRallev
Copy required annotations to generated code
2e98732 
Copy all annotations from `expect fun` functions annotated with `@CreateComponent` to the generated `actual fun` functions to avoid a Kotlin compiler warning.

Fixes #72
@vRallev vRallev self-assigned this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vRallev vRallev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZacSweers @vRallev