Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor inbatch_parallel #672

Open
3 tasks
SergeyTsimfer opened this issue Oct 3, 2022 · 2 comments
Open
3 tasks

Refactor inbatch_parallel #672

SergeyTsimfer opened this issue Oct 3, 2022 · 2 comments
Assignees

Comments

@SergeyTsimfer
Copy link
Member

As the inbatch_parallel now not supposed to be used on its own, we can refactor it with following goals in mind:

  • remove _use_self args
  • remove init/post functions: the container with init should be passed directly from Batch.apply_parallel, and the results should be post-processed in the Batch.apply_parallel as well
  • make inbatch_parallel a class: that would allow for easier introspection and parameter changes on the fly, for example, target to any other.
@SergeyTsimfer
Copy link
Member Author

use inspect to check whether src/dst should be passed to the method

@roman-kh
Copy link
Member

Avoid inspect if possible. Use inbatch_parallel arguments instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants