Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow @'s in distribution filenames ? #509

Open
andk opened this issue May 11, 2024 · 2 comments
Open

disallow @'s in distribution filenames ? #509

andk opened this issue May 11, 2024 · 2 comments

Comments

@andk
Copy link
Owner

andk commented May 11, 2024

16:33:31 <sjn> ok, do you mind if we disallow @'s in distribution filenames going forward?
16:34:11 <sjn> the reason for this is that in package urls, the @ is used as a delimiter between the package name and package version
16:35:36 <sjn> e.g. pkg:cpan/ANDK/[email protected]
16:35:57 <sjn> if @'s are allowed, we'll have to escape them
16:37:13 <sjn> it's not a big problem (and can still be done, since the dist name in pkgurls can be URL-encoded), but it would be a really nice-to-have for usability's sake

I've checked the uris table and we had only 47 uploads with an '@' in the name; the last one of those dates back to 2007. I'm not opposed to this change request. Opinions welcome.

@rjbs
Copy link
Collaborator

rjbs commented May 11, 2024

Sounds okay to me, and happy to code it once I finish getting #405 through review.

@Grinnz
Copy link
Contributor

Grinnz commented May 11, 2024

Seems like a reasonable restriction as long as it is clearly communicated, this character is quite rarely used in filenames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants