Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter old metrics using maxMetricAgeMs #4

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Filter old metrics using maxMetricAgeMs #4

merged 2 commits into from
Apr 20, 2023

Conversation

MeenaAlfons
Copy link
Contributor

Fixes #3

@andrasq andrasq changed the base branch from master to fix-max-age April 20, 2023 05:00
andrasq
andrasq approved these changes Apr 20, 2023
View reviewed changes
Copy link
Owner

@andrasq andrasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the fix! I'm merging it into a branch so can update the readme and bump the version number and write tests for it.

@andrasq andrasq merged commit a8502a6 into andrasq:fix-max-age Apr 20, 2023
@andrasq
Copy link
Owner

andrasq commented Apr 23, 2023

merged, added tests, added comments, updated readme, fixed the Buffer deprecation warnings
published [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrasq andrasq andrasq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling GET /metrics results in clearing all cached metrics
2 participants
@MeenaAlfons @andrasq