Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE after deleting data file #22

Open
andrepl opened this issue Jun 11, 2013 · 7 comments
Open

NPE after deleting data file #22

andrepl opened this issue Jun 11, 2013 · 7 comments

Comments

@andrepl
Copy link
Owner

andrepl commented Jun 11, 2013

Another strange case is passing a box to my alt and letting him build at my ground with trust.
success, but one frontdoor needed to be corrected as it opened asyncronous. So i delete my file and makes a new one. Now i get errors when my alt wants to spawn the box, and the box wont loosen from the ground.

07:06:47 [WARNING] [BuildInABox] Task #3150 for BuildInABox v0.2.1-SNAPSHOT generated an exception
java.lang.NullPointerException
at com.norcode.bukkit.schematica.Clipboard.copyBlockToWorld(Clipboard.java:624)
at com.norcode.bukkit.buildinabox.BuildChest$4.processBlock(BuildChest.java:334)
at com.norcode.bukkit.buildinabox.BuildManager$BuildTask.tick(BuildManager.java:90)
at com.norcode.bukkit.buildinabox.BuildManager.run(BuildManager.java:41)
at org.bukkit.craftbukkit.v1_5_R3.scheduler.CraftTask.run(CraftTask.java:53)
at org.bukkit.craftbukkit.v1_5_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
at net.minecraft.server.v1_5_R3.MinecraftServer.r(MinecraftServer.java:513)
at net.minecraft.server.v1_5_R3.DedicatedServer.r(DedicatedServer.java:226)
at net.minecraft.server.v1_5_R3.MinecraftServer.q(MinecraftServer.java:477)
at net.minecraft.server.v1_5_R3.MinecraftServer.run(MinecraftServer.java:410)
at net.minecraft.server.v1_5_R3.ThreadServerApplication.run(SourceFile:573)

@andrepl
Copy link
Owner Author

andrepl commented Jun 11, 2013

#20

@andrepl
Copy link
Owner Author

andrepl commented Jun 11, 2013

Which file did you delete? chests.yml or plans.yml?

@fungreenfox
Copy link

none of those. i deleted a hotelhouse by use of "/biab delete hotelkro".

@JyeGuru
Copy link

JyeGuru commented Aug 12, 2013

Just want to mention that I had this issue as well - if there are any spawned copies of a template, then they become quite broken after deleting that template. There's also no easy way to tell if there are any copies spawned.

I haven't looked through the code, but I would hope it would be relatively simple to do something like, "on deconstruct, if template no longer exists, call 'make permanent' instead and throw an error."

@andrepl
Copy link
Owner Author

andrepl commented Aug 12, 2013

1b16489 should handle any interactions with existing chests when their plan is deleted, but I still need to handle the BlockPlace of a BIAB w/ a deleted plan. that's coming soon.

@JyeGuru
Copy link

JyeGuru commented Aug 14, 2013

Would it be possible to have the delete routine simply remove the item from player inventories? Even better if it's able to look across the world for any currently-deployed ones and autoperm them.

It's times like these I wish I knew a little more about plugin development so I could look through the code and see what I can do to help.

@andrepl
Copy link
Owner Author

andrepl commented Aug 14, 2013

it COULD go through player inventories, but it can't check all the chests and other containers in the world, so theres no guarantee it will find/remove all instance of the chest. it can scan for all existing buildings, but that too, is a bit heavy of a task when we can just react on the first interaction of the chest. I will look into that as an option though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants