Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly device names for TS0000 by _TZ0000_abcdefgh #3128

Closed
3 tasks done
amis92 opened this issue Feb 18, 2025 · 1 comment
Closed
3 tasks done

Friendly device names for TS0000 by _TZ0000_abcdefgh #3128

amis92 opened this issue Feb 18, 2025 · 1 comment

Comments

@amis92
Copy link

amis92 commented Feb 18, 2025

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

First of all, thank you for such a great integration, and wow the battery/device submission workflow provides a really great contributing experience!

It came up because I contributed some new devices configs:

And while I did include a friendly/product/branding name in the issue title, it got renamed to the model/manufacturer values (which is fine), but as a result the "market" name (at least one of them) was lost in the issue change events.

Describe the solution you'd like

I'd love to be able to see some friendly names/example brandings of the nameless tuya/chinese origin. There was a discussion about _TZ/TS devices in #190 but in a bit different topic. So, I'd like to suggest adding a new optional field like "branding_name(s)"/"friendly_name(s)" so that there's at least a chance to find the product in google or compare with other databases etc. Or some other field that would allow adding that kind of value.

Describe alternatives you've considered

It's informative and non-critical, so just leave the db as is, no changes.

Additional context

Image

@andrew-codechimp
Copy link
Owner

Thanks for the feedback, you actually prompted me to change that description to say it's overwritten automatically and stop people wasting time.

The tuya devices are very strangely named and since I don't own everything in the list I'm relying on contributors to be accurate. I'm not sure what a comment/description would add other than an explainer in the markdown library doc, it wouldn't add any value in the library that's downloaded to the integration and would increase the library size so at this point I don't see myself adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants