Skip to content
This repository has been archived by the owner on Dec 11, 2021. It is now read-only.

Adding basic email headers breaks HTML #123

Open
broth-itk opened this issue Sep 5, 2020 · 3 comments
Open

Adding basic email headers breaks HTML #123

broth-itk opened this issue Sep 5, 2020 · 3 comments

Comments

@broth-itk
Copy link

broth-itk commented Sep 5, 2020 •
edited
Loading

Payload has valid HTML code.
The headers will be added in front of the <html> start tag which breaks HTML standard:

if args.headers:
            header_info = get_formatted_header_info(input_email)
            logger.info("Header info is: " + header_info)
            payload = header_info + payload
@broth-itk
Copy link
Author

Proposal:

if args.headers:
            header_info = get_formatted_header_info(input_email)
            logger.info("Header info is: " + header_info)
            soup = BeautifulSoup(payload, "html.parser")
            soup.body.insert(1, BeautifulSoup(header_info, 'html.parser'))
            payload = str(soup)

@andrewferrier
Copy link
Owner

@broth-itk I think I get the general intent here, but what kind of problem are you trying to solve specifically? In practice, this generally speaking seems to work for me. I'm cautious about running the email body through the BS parser unless there's a compelling reason to do so.

@broth-itk
Copy link
Author

@andrewferrier: Thanks for your feedback! I just wanted to point out that the HTML code will be invalidated when adding headers. wkhtmltopdf does seem to handle that issue fine but IMHO we should feed it with proper HTML code.
In my case I modified the script to add even another header to the resulting HTML code. This might get me into troubles.

I am not a fan sending all though BS parser as well. Maybe it's simpler to search the string for <body> tag and insert the code right there. Will have the same effect IMHO.

Just my 2 cents

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewferrier @broth-itk