-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why GenServer to hold the document? #25
Comments
@alappe I know this was some time ago, but would you be willing to share your version? |
@Hermanverschooten sure, but it will take until next week due to holiday. |
@Hermanverschooten Sorry, I forgot it's on github anyway: https://github.com/zimmer7/elixir-pdf/tree/document_without_process This is the branch I'm using in one project. |
@alappe Thanks! Small question though, why did you change the name to |
I can't recall, probably because it worked and that's the usual writing of the format. This complicates merging – sorry for that! Looking into it, I wasn't really that wrong: https://hexdocs.pm/elixir/1.12/naming-conventions.html#casing |
Wasn't complaining, just wondering. |
Alright :) |
Dear Andrew,
thanks for starting this package – much appreciated. While converting an old pdf over to your library, I wondered why the document is hold inside a GenServer? I read through it and even converted a local version to return the
%Document{}
instead of apid()
, all working fine.I do see a benefit for holding fonts and objects though.
Regards
Andreas
The text was updated successfully, but these errors were encountered: