Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

press interval #1

Open
realAbitbol opened this issue Nov 22, 2021 · 2 comments
Open

press interval #1

realAbitbol opened this issue Nov 22, 2021 · 2 comments

Comments

@realAbitbol
Copy link
Contributor

realAbitbol commented Nov 22, 2021

Hey o/

Thanks for this really cool program.
It's almost on Bard Music Player level but there's something that makes to perform worse with some songs that have many notes really close together (almost like chords).

It looks like your program has something of a delay between keystrokes even when the midi note duration is 0. That delay is somehow way greater that the one of Bard Music Player which makes some songs perform awkwardly.

I tried fiddling with the ticks2s function but it doesn't seem to do anything and afaik that function isn't used anywhere.

I'll keep looking to find a solution but it would be awesome if you could have a look at it too.

Regards

@realAbitbol
Copy link
Contributor Author

Daemindra_Ejinn_Cascada_-_Everytime_We_Touch.mid.zip

For example this song performs worse

@realAbitbol
Copy link
Contributor Author

realAbitbol commented Nov 22, 2021

I'va had some success with some songs by adding the following to the start of the main function (needs a full pyautogui import)
pyautogui.PAUSE = 0

Gonna make a PR with that already because it already improves things a lot.

Unfortunately it doesn't fix the song I linked fully.
It seems this mid file (from the BMP discord) is spamming some keys in order to do long notes. Maybe that's another problem but I don't really know how to fix it yet.

angrymarker pushed a commit that referenced this issue Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant