🚸Describe why Parse fails due to case-insensitive ambiguity

[angularsen]

Fixes #1423

UnitParser.Parse<LengthUnit>("MM") fails due to matching both Megameter and Millimeter in case-insensitive matching, but matches neither of them in the case-sensitive fallback. It was confusing to get UnitsNotFoundException in this case, since case-insensitive usually works for most units.

Changes

• Handle this case and throw AmbiguousUnitParseException instead of UnitNotFoundException
• Describe the case-insensitive units that matched
• Fix existing test Parse_WithMultipleCaseInsensitiveMatchesButNoExactMatches_ThrowsUnitNotFoundException
• Skip retrying with fallback culture if no specific formatProvider was given

[angularsen]

@lipchev relevant to your exception helpers PR, the exception message can be improved further to include information about the quantity and unit enum type, which I believe you already did there.

[lipchev]

@lipchev relevant to your exception helpers PR, the exception message can be improved further to include information about the quantity and unit enum type, which I believe you already did there.

Yes, I was also going to bring this is up (eventually) - if we want to go wild we could even include extra fields like in these examples:

               throw new UnitNotFoundException($"No unit was found for quantity '{quantityName}' with the name: '{unitName}'.")
               {
                   Data = { ["quantityName"] = quantityName, ["unitName"] = unitName }
               };

        throw new UnitNotFoundException($"No quantity was found with the specified unit type: '{unitType}'.") { Data = { ["unitType"] = unitType.Name } };

[angularsen]

Fixed test case that broken in CI, due to different current culture: def3211

https://dev.azure.com/unitsnet/Units.NET/_build/results?buildId=1004&view=ms.vss-test-web.build-test-results-tab&runId=245&resultId=116706&paneView=debug

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84%. Comparing base (bb1420e) to head (def3211).
Report is 1 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #1484   +/-   ##
======================================
  Coverage      84%     84%           
======================================
  Files         368     368           
  Lines       35601   35606    +5     
======================================
+ Hits        30000   30005    +5     
  Misses       5601    5601           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[angularsen]

@lipchev Are you still reviewing this or can I merge?

[lipchev]

@lipchev Are you still reviewing this or can I merge?

Well, my earlier comment wasn't about the test that broke the build - it was a bit more subtle than that..
Nevertheless, I would say "merge it" as fixing that very unlikely case would be an unpleasant endeavor (and testing it would probably require setting up custom abbreviation mappings etc.), so I think it would be easier if we just add it like it is and try to fix it better in v6.

[angularsen]

Gotcha, I'll merge this then.