Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decomposed the rounded expressions in the unit definitions into operations with exact coefficients (breaking) #1499

Open
wants to merge 1 commit into
base: release/v6
Choose a base branch
from

Conversation

lipchev
Copy link
Collaborator

@lipchev lipchev commented Jan 19, 2025

This is a port of #1393, targeting the release-v6 consisting of the changes that broke one test or another.

Most of these are related to conversions involving the US/British units but there is also some confusion regarding the Calorie - the value of 4.1868 was used (instead of 4.184) in a few places, which is a note-worthy difference.

Here are all the tests that broke:

@lipchev
Copy link
Collaborator Author

lipchev commented Jan 19, 2025

I still want to replace the PressureUnit.FeetOfElevation and PressureUnit.MeterOfElevation with properties that convert to/from Length (see #1393 (comment)) and remove the Frequency.BUnit but I'll open separate PRs for these (didn't want to have the Units.g.json changed here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant