Decomposed the rounded expressions in the unit definitions into operations with exact coefficients (breaking) #1499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #1393, targeting the release-v6 consisting of the changes that broke one test or another.
Most of these are related to conversions involving the US/British units but there is also some confusion regarding the Calorie - the value of
4.1868
was used (instead of4.184
) in a few places, which is a note-worthy difference.Here are all the tests that broke:
HeatFlux
: due to the change inCalorie
HeatTransferCoefficient
: due to the change inCalorie
Impulse
:PoundFootPerSecond
,SlugFootPerSecond
were represented by a single coefficient that is significantly different from what got: see Decomposed the rounded expressions in the unit definitions into operations with exact coefficients #1393 (comment)Luminosity
: see Decomposed the rounded expressions in the unit definitions into operations with exact coefficients #1393 (comment).Power
: MechanicalHorsepower changed from{x} * 745.69
to{x} * 76.0402249 * 9.80665
as given by this articlePressure
the TechnicalAtmosphere coefficient (no idea where the old one was taken from), see also Decomposed the rounded expressions in the unit definitions into operations with exact coefficients #1393 (comment)SpecificFuelConsumption
: I'm not a domain expert, but{x} * 28.33
doesn't look right forPoundMassPerPoundForceHour
(lb/(lbf·h))- here's what I got:{x} * 453.59237 / (0.0044482216152605 * 3600)
ThermalResistance
: using different conversion coefficients forBTU
andCalorie
from the one defined inEnergy
(note: I wasn't able to confirm the "correct" conversion coefficient for BTU).VolumetricHeatCapacity
: using different conversion coefficient forCalorie