Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI NDK install by using nttld/setup-ndk #406

Open
mikehardy opened this issue Aug 20, 2024 · 1 comment
Open

Improve CI NDK install by using nttld/setup-ndk #406

mikehardy opened this issue Aug 20, 2024 · 1 comment
Labels
ci good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mikehardy
Copy link
Member

Currently we have an install_ndk.bat script here and an install_ndk.sh script for *nix
There is a community action though, and we should just use that

https://github.com/nttld/setup-ndk

Originally posted by @mikehardy in #402 (comment)

@mikehardy mikehardy added help wanted Extra attention is needed good first issue Good for newcomers ci labels Aug 20, 2024
@mikehardy
Copy link
Member Author

There was a flake just now which added some requirements, that is:

  • the install NDK should probably be wrapped in a retry if possible? (though community action may not support it) because network failures happen and this is a big network resource fetch
  • it cannot silently succeed if there is a failure

Failure seen in current script was:

Warning: Still waiting for package manifests to be fetched remotely.
Warning: Still waiting for package manifests to be fetched remotely.
Warning: Still waiting for package manifests to be fetched remotely.
Warning: Still waiting for package manifests to be fetched remotely.
Warning: Still waiting for package manifests to be fetched remotely.
Warning: Still waiting for package manifests to be fetched remotely.
Warning: Still waiting for package manifests to be fetched remotely.
Warning: Still waiting for package manifests to be fetched remotely.
Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
Warning: An error occurred while preparing SDK package NDK (Side by side) 27.0.1[20](https://github.com/ankidroid/Anki-Android-Backend/actions/runs/11296483641/job/31421447527?pr=423#step:7:21)77973: Archive is not a ZIP archive.

...but it silently proceeded and then later on failed during a build step where the NDK was needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant