Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old settingsgen, zip compression and related env vars and module vars #3404

Open
mkundu1 opened this issue Oct 18, 2024 · 1 comment
Assignees

Comments

@mkundu1
Copy link
Contributor

mkundu1 commented Oct 18, 2024

will do after the next version of PyFluent is stabilized in Fluent 25.2

@mkundu1 mkundu1 self-assigned this Oct 18, 2024
@mkundu1
Copy link
Contributor Author

mkundu1 commented Oct 28, 2024

Also, review the following code in flobject.py in light of the new settingsgen:

        original_pname = pname
        i = 1
        if parent_taboo:
            while pname in parent_taboo:
                pname = f"{original_pname}_{i}"
                i += 1
        parent_attr_name = pname
        if info.get("file_purpose"):  # not generalizing for performance
            while pname in _bases_by_class and _bases_by_class[pname] != bases:
                pname = f"{original_pname}_{i}"
                i += 1
            _bases_by_class[pname] = bases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant