Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Models into Per-Package Package #20

Open
da1910 opened this issue Dec 8, 2022 · 0 comments
Open

Refactor Models into Per-Package Package #20

da1910 opened this issue Dec 8, 2022 · 0 comments

Comments

@da1910
Copy link
Collaborator

da1910 commented Dec 8, 2022

Currently models are all in the same ansys.materials.manager._models namespace. This is private, and contains models for all the supported solvers.

This is inconvenient, as it doesn't make the distinction between common and per-package models clear, and it means that users need to import a private module.

We should look at improving this, but there are a few things to think about...

  1. Do we want to separate these modules/packages out into separate packages?
  2. Do we want to import them into the main library, or do we leave them as external imports?
  3. How do we handle the case where more than one, but not all the package support the same model? This might make common substantially bigger than any of the solver specific packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant