Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty archive_unless_directed cause import errors #23

Open
FiloSottile opened this issue Jun 14, 2018 · 1 comment
Open

Empty archive_unless_directed cause import errors #23

FiloSottile opened this issue Jun 14, 2018 · 1 comment

Comments

@FiloSottile
Copy link
Contributor

A clause like

    filter {
      has [FOO]
    }.archive_unless_directed

will still generate two filters, one for directed emails and one for not, but the latter one will be empty, causing an import error.

@antifuchs
Copy link
Owner

Eeep, yes, that's a messy edge case. I think it would make sense in archive_unless_directed to check if the new filter is empty / identical to the base filter and not return a new one in that case (I don't have all the state swapped in at the moment, it might need some refactoring to let us not add a filter from this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants