-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Google+ token #26
Comments
Hello, Yes, it's simple to add getAccessToken, but by your example there is problem. |
@gorbin, I think it's not a problem, just implement common interface to get AccessToken as other requests, like requestAccessToken(Listener). For other social networks callback will be called immediately. |
@antonkrasov, yes, I mean this, it's not a problem, but maybe as I some one use it like me without listener, but now will ned llistener, just warning |
@gorbin, yes, I see, I think we can add requestAccessToken, and mark getAccessToken method as deprecated, and remove it after couple of new releases. |
For now it would be possible to add GoogleAuthUtil#getToken to the AccessToken#getAccessToken method and let everyone handle the Thread/Asynctask themselves. |
@ChrisMCMine, I don't think it's a good idea, library was planned to be simple to use, so you can add it, initialize SocialNetworkManager and you shouldn't worry about anything else. People don't read docs, and they will have issues, if getAccessToken will be blocking... Sure we can check Thread in getAccessToken and throw an exception if it equals to Main, but it's much better just to add requestAccessToken. |
yeah but I meant one method with callback/listener and a second optional one which performs a blocking request. |
Add in pull request interface and requestAccessToken, but save getAccessToken, I think it can be useful, at least for me) |
@gorbin Do you make the pul request? I can't find the requestAccessToken in the main project |
Thank you very much @gorbin , I will try your library |
Please add support for retrieving the Google+ Token. Example [here](http://developer.android.com/reference/com/google/android/gms/auth/GoogleAuthUtil.html#getToken%28android.content.Context, java.lang.String, java.lang.String%29)
The text was updated successfully, but these errors were encountered: