refactor(graph): optimize graph api, improve docs #6792
Conversation
WalkthroughThis pull request refactors the graph API by optimizing the performance of Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| */ | ||
| public getNodeData(ids: ID[]): NodeData[]; | ||
| public getNodeData(id?: ID | ID[]): NodeData | NodeData[] { | ||
| if (id === undefined) return this.context.model.getNodeData(); | ||
| if (Array.isArray(id)) return this.context.model.getNodeData(id); | ||
| return this.context.model.getNodeData([id])?.[0]; | ||
| return this.context.model.getNodeLikeDatum(id); |
There was a problem hiding this comment.
The change from getNodeData([id])?.[0] to getNodeLikeDatum(id) improves performance by directly accessing the node datum without wrapping it in an array. Ensure that getNodeLikeDatum handles non-existent IDs appropriately to avoid runtime errors.
| */ | ||
| public getEdgeData(ids: ID[]): EdgeData[]; | ||
| public getEdgeData(id?: ID | ID[]): EdgeData | EdgeData[] { | ||
| if (id === undefined) return this.context.model.getEdgeData(); | ||
| if (Array.isArray(id)) return this.context.model.getEdgeData(id); | ||
| return this.context.model.getEdgeData([id])?.[0]; | ||
| return this.context.model.getEdgeDatum(id); |
There was a problem hiding this comment.
The change from getEdgeData([id])?.[0] to getEdgeDatum(id) enhances performance by directly accessing the edge datum. Verify that getEdgeDatum properly manages cases where the ID does not exist to prevent potential exceptions.
| */ | ||
| public getComboData(ids: ID[]): ComboData[]; | ||
| public getComboData(id?: ID | ID[]): ComboData | ComboData[] { | ||
| if (id === undefined) return this.context.model.getComboData(); | ||
| if (Array.isArray(id)) return this.context.model.getComboData(id); | ||
| return this.context.model.getComboData([id])?.[0]; | ||
| return this.context.model.getNodeLikeDatum(id); |
There was a problem hiding this comment.
The update from getComboData([id])?.[0] to getNodeLikeDatum(id) optimizes the retrieval process by directly accessing the combo datum. Confirm that getNodeLikeDatum correctly handles scenarios where the combo ID is missing to avoid errors.
getNodeData、getEdgeData、getComboDataAPI performanceRelative Issue: #6784