Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotify_player stop music when quitting it #567

Open
oliv3340 opened this issue Sep 30, 2024 · 5 comments
Open

spotify_player stop music when quitting it #567

oliv3340 opened this issue Sep 30, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@oliv3340
Copy link

Hi, thanks for your work. Awesome app! I use it and love it a lot!

Describe the bug
When I launch a song in spotify_player (the Spotify app launches but does not play anything), it works but stops as soon as I quit the app from the terminal. However, if I launch a song from Spotify itself first, other manipulations work as expected.
When I play music from spotify_player, I can relaunch it after quitting spotify_player using the "play" button on my keyboard, but it would be better if the music didn't stop at all. I don't know if something can be done about this.

To Reproduce
On macOS (I don't know about other systems):

  1. Launch the Spotify app.
  2. Play a song in spotify_player.
  3. Quit spotify_player (the music should stop).

Expected behaviour
Music shouldn't stop after quitting spotify_player.

Log and backtrace
Only infos in logs (nothing intersting) and no backtrace on the issue.

Environment

  • OS: MAC OS 15.0 (Apple silicon)
  • Application version: spotify_player v0.19.1, spotify 1.2.47.364.gf06e5cee

Additional context
I've install spotify_player with homebrew.

@oliv3340 oliv3340 added the bug Something isn't working label Sep 30, 2024
@aome510
Copy link
Owner

aome510 commented Oct 2, 2024

hmm music stops when you close the app is kinda unexpected when streaming is handled by the app. Not sure what is the bug here. Do you specifically mean if you stream music from an external source and use spotify_player as the remote control device, quitting the app stops the music played by the external source?

@derekbunch
Copy link

derekbunch commented Oct 9, 2024

this also happens for me.

if i start streaming from the spotify app it will keep playing, but if i start playing from spotify_player it will stop as soon as spotify_player is quit.

ive tested these scenarios

  1. spotify app is running, but not playing anything
  2. start music with spotify_player
  3. quit spotify_player
  4. music stops ❌

  1. spotify app not running
  2. start music with spotify_player
  3. quit spotify_player
  4. music stops ❌

  1. start music with spotify app
  2. change track with spotify_player
  3. quit spotify_player
  4. music still plays ✅

  1. spotify app is running, but not playing anything
  2. start music with spotify_player
  3. change music with spotify app
  4. quit spotify_player
  5. music stops ❌

so it seems to be only when streaming originates from spotify_player

Environment
macOS Sonoma 14.6.1 (23G93) (M3 Pro, Nov 2023 MacBook Pro 16)

❯ spotify_player -V
spotify_player 0.19.1

@aome510
Copy link
Owner

aome510 commented Oct 9, 2024

look expected to me. Not sure why you guys expect music to continue playing when exiting the spotify_player app when music is from the app.

@derekbunch
Copy link

derekbunch commented Oct 10, 2024

I don't think we expected it to keep running (or that was not my understanding). It makes sense that it doesn't.

I think we were just saying it would be nice if it could continue running after exiting (like with a daemon or something)

Edit: I guess to be fair, I can just ctrl-z or run it in a tmux pane and it's fine, not a big deal

@aome510
Copy link
Owner

aome510 commented Oct 14, 2024

I think we were just saying it would be nice if it could continue running after exiting (like with a daemon or something)

I see. That means it should be feature request instead of a bug report. spotify_player does support daemon mode. See https://github.com/aome510/spotify-player?tab=readme-ov-file#daemon for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants