feat: add rounding logic and scale zero fix fro parse_decimal to match parse_string_to_decimal_native behavior #7179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himadripal
force-pushed
the
fix_parse_decimal_for_rounding_scale_zero
branch
from
bbd54d4 to
7b33527
Compare
tustvold
added
api-change
10 tasks
himadripal
force-pushed
the
fix_parse_decimal_for_rounding_scale_zero
branch
from
7e598c9 to
bef2992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Few important consideration -
parse_string_to_decimal_nativeparse_string_to_decimal_nativedoes not have support for e-notationparse_string_to_decimal_nativedoes rounding at scale, not truncateparse_decimalan existing method has e-notation support and use elsewhereparse_decimalparse_decimalto get support for e-notation.This PR is a 2nd one to break up #6905 , this one add rounding logic to parse_decimal to match the behavior in existing
parse_string_to_decimal_native.Closes #.
Rationale for this change
At present, string to decimal conversion does not support e-notation, in arrow,
parse_string_to_decimal_nativeis called to get generic string to decimal. parse_decimal on the other hand is used from generic parse method and it has e-notation support. This PR is adding rounding and scale 0 handling to match the behavior orparse_string_to_decimal_nativemethod. Then we can replaceparse_string_to_decimal_nativecall withparse_decimal. This way, we will get e-notation support too.What changes are included in this PR?
Are there any user-facing changes?