Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlightRPC] Explore using HTTP status codes as the canonical status definition #36722

Closed
lidavidm opened this issue Jul 17, 2023 · 1 comment
Closed

Comments

@lidavidm
Copy link
Member

lidavidm commented Jul 17, 2023

Describe the enhancement requested

We currently ad-hoc map through some of gRPC's status codes and awkwardly map to Arrow status codes (in C++) or a custom exception (in Java). Ideally we'd always expose exactly a consistent set of Flight status codes (this makes it easier to predict behavior across languages, at maybe the cost of a little convenience for someone only working in a single language)

Also see

Component(s)

FlightRPC

@lidavidm
Copy link
Member Author

Googleapis already defines canonical mappings between gRPC and HTTP status codes. However, these are lossy in both directions. Given that, I'd rather stick with the canonical gRPC codes for Flight since we already use them, and we should just update the Flight codes to be 1:1 with gRPC (e.g. to fix #35888).

We could define our own symmetric mapping, but I'd rather not risk doing something that would confuse people who also want to use existing gRPC infrastructure (e.g. HTTP proxies).

@lidavidm lidavidm closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant