GH-36856: [C++] Remove needless braces from BasicDecimal256FromLE() arguments #36987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LE() arguments
BasicDecimal256FromLE() requires 4 arguments. So we should not use
BasicDecimal256FromLE({X, X, X, X}) form.
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 4b70fd4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
barracuda156
pushed a commit
to barracuda156/arrow
that referenced
this pull request
Aug 14, 2023
…LE() arguments (apache#36987) ### Rationale for this change BasicDecimal256FromLE() requires 4 arguments. So we should not use BasicDecimal256FromLE({X, X, X, X}) form. I don't know why the current form works on amd64 but doesn't work on s390x. ### What changes are included in this PR? Removed needless "{" and "}". ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#36856 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…LE() arguments (apache#36987) ### Rationale for this change BasicDecimal256FromLE() requires 4 arguments. So we should not use BasicDecimal256FromLE({X, X, X, X}) form. I don't know why the current form works on amd64 but doesn't work on s390x. ### What changes are included in this PR? Removed needless "{" and "}". ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#36856 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
BasicDecimal256FromLE() requires 4 arguments. So we should not use BasicDecimal256FromLE({X, X, X, X}) form.
I don't know why the current form works on amd64 but doesn't work on s390x.
What changes are included in this PR?
Removed needless "{" and "}".
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.