[C++][S3] CRT support may not be detected #37394
Comments
kou
added a commit
to kou/arrow
that referenced
this issue
Aug 25, 2023
kou
added a commit
to kou/arrow
that referenced
this issue
Aug 25, 2023
kou
added a commit
that referenced
this issue
Aug 30, 2023
…37395) ### Rationale for this change I don't know why but `try_compile()` based `Aws::SDKOptions::ioOptions` detection seems not work on some environments. Some unrelated errors may be happen. ### What changes are included in this PR? Using `AWS_SDK_VERSION_{MAJOR,MINOR,PATCH}` instead of `try_compile()`. Downside: `AWS_SDK_VERSION_*` are available since 1.9.7 or later but `Aws::SDKOptions::ioOptions` is available since 1.9.0. So we can't detect `Aws::SDKOptions::ioOptions` with [1.9.0,1.9.6]. I think that it's acceptable. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #37394 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…e() (apache#37395) ### Rationale for this change I don't know why but `try_compile()` based `Aws::SDKOptions::ioOptions` detection seems not work on some environments. Some unrelated errors may be happen. ### What changes are included in this PR? Using `AWS_SDK_VERSION_{MAJOR,MINOR,PATCH}` instead of `try_compile()`. Downside: `AWS_SDK_VERSION_*` are available since 1.9.7 or later but `Aws::SDKOptions::ioOptions` is available since 1.9.0. So we can't detect `Aws::SDKOptions::ioOptions` with [1.9.0,1.9.6]. I think that it's acceptable. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37394 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…e() (apache#37395) ### Rationale for this change I don't know why but `try_compile()` based `Aws::SDKOptions::ioOptions` detection seems not work on some environments. Some unrelated errors may be happen. ### What changes are included in this PR? Using `AWS_SDK_VERSION_{MAJOR,MINOR,PATCH}` instead of `try_compile()`. Downside: `AWS_SDK_VERSION_*` are available since 1.9.7 or later but `Aws::SDKOptions::ioOptions` is available since 1.9.0. So we can't detect `Aws::SDKOptions::ioOptions` with [1.9.0,1.9.6]. I think that it's acceptable. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#37394 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
See the following comments:
Component(s)
C++
The text was updated successfully, but these errors were encountered: