Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release][C++] Check the ABI stability during the release process of bug-fix releases #41708

Open
jorisvandenbossche opened this issue May 17, 2024 · 2 comments

Comments

@jorisvandenbossche
Copy link
Member

According to our current policy, bug-fix (micro) releases of the C++ libraries are expected to be ABI stable, and so versions are not bumped (we should better document this, though, for which I opened #41707).

However, AFAIK we don't actually check for this, and I am also not sure if we pay much attention to that aspect when deciding to backport certain PRs to the release branch.
We do have a section in the dev docs about how to check for this (https://arrow.apache.org/docs/dev/developers/cpp/development.html#checking-for-abi-and-api-stability), and if we promise ABI stability, then I think we should do a better job of actually checking for this during the release process, and run that tool as part of the release process / verification? (or in some CI build, although one that should only run on the maintenance branches)

Example issue where we recently had an ABI break in 15.0.1: #40604 (although I haven't checked if the tool mentioned above would have caught this)

cc @raulcd @kou

@jorisvandenbossche
Copy link
Member Author

Older closed issue about including the abi-compliance-checker tool in the build process: #17960

@kou
Copy link
Member

kou commented May 19, 2024

+1

We should do it to follow semantic versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants