-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41867: [Java] Parallel to build JNI C++ code #41868
Conversation
|
should we also add some documentation regarding setting a fixed parallelism for Java users (in case of there are concerns on full resource utilization)? |
@github-actions crossbow submit -g java |
Revision: 3c8bda8 Submitted crossbow builds: ursacomputing/crossbow @ actions-10f0171d4b |
Do we need to add |
I am not sure if this is a standard maven property? But if we can introduce such a variable to the root and document in cc @lidavidm |
No, it will be arrow defined property. Current |
Does CMAKE_PARALLEL_LEVEL not already work? |
Sorry that should be |
I haven't actually checked this. @jinchengchenghh could we verify this? |
@jinchengchenghh need any help here? |
It works, but I think the default parallel mode should be parallel build mode. |
As is though, this forces parallelism which may also be undesirable |
ok, I will close this PR |
Rationale for this change
Accelerate the default JNI C++ build process
What changes are included in this PR?
Add
-j
to cmake build commandAre these changes tested?
Current tests covered.
Are there any user-facing changes?
No