Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift] Ensure map behavior is the same between all data types #42245

Closed
abandy opened this issue Jun 21, 2024 · 2 comments
Closed

[Swift] Ensure map behavior is the same between all data types #42245

abandy opened this issue Jun 21, 2024 · 2 comments
Assignees
@abandy
Labels
Component: Swift Type: enhancement
Milestone
17.0.0

Comments

@abandy
Copy link
Contributor

abandy commented Jun 21, 2024

Describe the enhancement requested

Currently we are decoding a map into an array which means that each key/value pair is placed in its own map. This is not the desired behavior. A RecordBatch that is decoded into a map needs to put all the key/value pairs into the same map.

Component(s)

Swift
@abandy
Copy link
Contributor Author

abandy commented Jun 21, 2024

take

abandy added a commit to abandy/arrow that referenced this issue Jun 21, 2024
@abandy
apacheGH-42245: [Swift] Ensure map behavior is the same for all key t…
f00d5aa 
…ypes
abandy added a commit to abandy/arrow that referenced this issue Jun 21, 2024
@abandy
apacheGH-42245: [Swift] Ensure map behavior is the same for all key t…
bb2dfdd 
…ypes
@github-actions github-actions bot mentioned this issue Jun 21, 2024
Merged
abandy added a commit to abandy/arrow that referenced this issue Jun 22, 2024
@abandy
apacheGH-42245: [Swift] Ensure map behavior is the same for all key t…
7afb5e8 
…ypes
kou pushed a commit that referenced this issue Jun 22, 2024
@abandy
GH-42245: [Swift] Ensure map behavior is the same for all key types (#…
d28078d 
…42246)

### Rationale for this change
Behavior of decoding a map currently changes based on the key type (String or not String)

### What changes are included in this PR?
Added method for handling map to ensure that all maps are decoded the same way.

### Are these changes tested?
Yes

* GitHub Issue: #42245

Authored-by: Alva Bandy <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 17.0.0 milestone Jun 22, 2024
@kou
Copy link
Member

kou commented Jun 22, 2024

Issue resolved by pull request 42246
#42246

@kou kou closed this as completed Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abandy abandy

Labels
Component: Swift Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@kou @abandy