Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][C++] test-ubuntu-22.04-cpp-emscripten fails on CSV tests #43175

Closed
raulcd opened this issue Jul 8, 2024 · 3 comments
Closed

[CI][C++] test-ubuntu-22.04-cpp-emscripten fails on CSV tests #43175

raulcd opened this issue Jul 8, 2024 · 3 comments
Assignees
@kou
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
18.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Jul 8, 2024

Describe the bug, including details regarding any error messages, version, and platform.

The following issue #41910 introduced ARROW_CSV=ON on emscripten and 4 tests related to CSV have started failing on the CI job, see (https://github.com/ursacomputing/crossbow/actions/runs/9823190677/job/27120792147).

Part of the error can be seen here:

Failed
'_error_or_value15.status()' failed with Invalid: CSV conversion error to timestamp[s, tz=America/Phoenix]: invalid value '01/02/1970 +0000'
/arrow/cpp/src/arrow/csv/converter.cc:543  decoder_.Decode(data, size, quoted, &value)
/arrow/cpp/src/arrow/csv/parser.h:123  status
/arrow/cpp/src/arrow/csv/converter.cc:547  parser.VisitColumn(col_index, visit)
/arrow/cpp/src/arrow/csv/converter_test.cc:69: Failure
Failed
'_error_or_value15.status()' failed with Invalid: CSV conversion error to timestamp[s, tz=America/Phoenix]: invalid value '01/02/1970 +0000'
/arrow/cpp/src/arrow/csv/converter.cc:543  decoder_.Decode(data, size, quoted, &value)
/arrow/cpp/src/arrow/csv/parser.h:123  status
/arrow/cpp/src/arrow/csv/converter.cc:547  parser.VisitColumn(col_index, visit)
[  FAILED  ] TimestampConversion.UserDefinedParsersWithZone (1 ms)
...
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] NullColumnDecoderTest.Threaded
[  FAILED  ] TypedColumnDecoderTest.Threaded
[  FAILED  ] InferringColumnDecoderTest.Threaded
[  FAILED  ] TimestampConversion.UserDefinedParsersWithZone

Component(s)

C++, Continuous Integration
@raulcd
Copy link
Member Author

raulcd commented Jul 8, 2024

This has started failing on the 17.0.0 release but this is not a blocker for the release.

@kou
Copy link
Member

kou commented Jul 9, 2024

@joemarshall Could you take a look at this?

kou added a commit to kou/arrow that referenced this issue Aug 16, 2024
@kou
apacheGH-43175: [C++] Skip not Emscripten ready tests in CSV tests
d54502a
@github-actions github-actions bot mentioned this issue Aug 16, 2024
Merged
kou added a commit that referenced this issue Aug 17, 2024
@kou
GH-43175: [C++] Skip not Emscripten ready tests in CSV tests (#43724)
49be60f 
### Rationale for this change

We can't use thread nor `%z` on Emacripten. Some CSV tests use them.

### What changes are included in this PR?

Skip CSV tests that use thread or `%z`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #43175

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member

kou commented Aug 17, 2024

Issue resolved by pull request 43724
#43724

@kou kou added this to the 18.0.0 milestone Aug 17, 2024
@kou kou closed this as completed Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@kou @raulcd