Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] R_existsVarInFrame isn't available earlier than R 4.2 #43194

Closed
jonkeane opened this issue Jul 8, 2024 · 2 comments · Fixed by #43243
Closed

[R] R_existsVarInFrame isn't available earlier than R 4.2 #43194

jonkeane opened this issue Jul 8, 2024 · 2 comments · Fixed by #43243
Assignees
@jonkeane
Labels
Component: R Type: bug
Milestone
18.0.0

Comments

@jonkeane
Copy link
Member

jonkeane commented Jul 8, 2024

Describe the bug, including details regarding any error messages, version, and platform.

In #43173 we switched to using R_existsVarInFrame instead of Rf_findVarInFrame3, but R_existsVarInFrame isn't available before R 4.2, so we will need to do something to switch on this.

Component(s)

R
@jonkeane
Copy link
Member Author

jonkeane commented Jul 8, 2024

This is the cause of the r binary build failures at https://github.com/ursacomputing/crossbow/actions/runs/9836224882/job/27151883727

@jonkeane jonkeane mentioned this issue Jul 13, 2024
Merged
@jonkeane
Copy link
Member Author

Issue resolved by pull request 43243
#43243

@jonkeane jonkeane added this to the 18.0.0 milestone Jul 14, 2024
jonkeane added a commit that referenced this issue Jul 18, 2024
@jonkeane
GH-43194: [R] R_existsVarInFrame isn't available earlier than R 4.2 (#…
5dabe5d 
…43243)

### Rationale for this change

`R_existsVarInFrame` doesn't exist before R 4.2, so we need to fall back to `Rf_findVarInFrame3` if it is not defined.

Resolves #43194

### What changes are included in this PR?

`ifdef`s

### Are these changes tested?

Yes, in our extended CI `test-r-versions`, `test-r-rstudio-r-base-4.1-opensuse155`

### Are there any user-facing changes?

No

* GitHub Issue: #43194

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonkeane jonkeane

Labels
Component: R Type: bug
Projects
None yet
Milestone
18.0.0
Development

Successfully merging a pull request may close this issue.

GH-43194: [R] R_existsVarInFrame isn't available earlier than R 4.2 jonkeane/arrow
1 participant
@jonkeane