Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Packaging] Wheels for manylinux arm64 are failing due to failures installing thrift from vcpkg #43204

Closed
raulcd opened this issue Jul 10, 2024 · 6 comments
Closed

[CI][Packaging] Wheels for manylinux arm64 are failing due to failures installing thrift from vcpkg #43204

raulcd opened this issue Jul 10, 2024 · 6 comments
Assignees
@raulcd
Labels
Component: Continuous Integration Component: Packaging Priority: Blocker Marks a blocker for the release Type: bug
Milestone
17.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Jul 10, 2024

Describe the bug, including details regarding any error messages, version, and platform.

For the last couple of days the nightlies for the arm64 wheels on manylinux have been failing with errors like:

#20 4225.8 [DEBUG] 1000: execute_process(curl --fail -L https://github.com/apache/thrift/archive/0.20.0.tar.gz --create-dirs --output /opt/vcpkg/downloads/apache-thrift-0.20.0.tar.gz.62659.part)
#20 4225.8 [DEBUG] 1000: cmd_execute_and_stream_data() returned 0 after  1177311 us
#20 4225.8 [DEBUG] Trying to hash /opt/vcpkg/downloads/apache-thrift-0.20.0.tar.gz.62659.part
#20 4225.8 [DEBUG] /opt/vcpkg/downloads/apache-thrift-0.20.0.tar.gz.62659.part has hash 86a609f5725506abc2109902b338cbaad85abf980f9d28c63e6e50a5c265dc10699372c4e91f5ee85d8d09fbcbb0dc17c19745b86d215b96bbf7d0a9270f0932
#20 4225.8 error: Failed to download from mirror set
#20 4225.8 error: File does not have the expected hash:
#20 4225.8 url: https://github.com/apache/thrift/archive/0.20.0.tar.gz
#20 4225.8 File: /opt/vcpkg/downloads/apache-thrift-0.20.0.tar.gz.62659.part
#20 4225.8 Expected hash: 5e4ee9870b30fe5ba484d39781c435716f7f3903793dc8aae96594ca813b1a5a73363b84719038ca8fa3ab8ef0a419a28410d936ff7b3bbadf36fc085a6883ae
#20 4225.8 Actual hash: 86a609f5725506abc2109902b338cbaad85abf980f9d28c63e6e50a5c265dc10699372c4e91f5ee85d8d09fbcbb0dc17c19745b86d215b96bbf7d0a9270f0932
#20 4225.8 [DEBUG] /opt/vcpkg/buildtrees/_vcpkg/src/vcpkg-tool-2024-04-23/src/vcpkg/base/downloads.cpp(997): 
#20 4225.8 [DEBUG] Time in subprocesses: 1177311us
#20 4225.8 [DEBUG] Time in parsing JSON: 6us
#20 4225.8 [DEBUG] Time in JSON reader: 0us
#20 4225.8 [DEBUG] Time in filesystem: 75us
#20 4225.8 [DEBUG] Time in loading ports: 0us
#20 4225.8 [DEBUG] Exiting after 1.2 s (1194295us)

This is also affecting the RC1 for 17.0.0

Component(s)

Continuous Integration, Packaging
@raulcd raulcd added Type: bug Priority: Blocker Marks a blocker for the release labels Jul 10, 2024
@raulcd raulcd added this to the 17.0.0 milestone Jul 10, 2024
@raulcd
Copy link
Member Author

raulcd commented Jul 10, 2024

Not all of them are related to thrift, some of them seem like connection problems.

@raulcd
Copy link
Member Author

raulcd commented Jul 10, 2024

I've downloaded locally and the sha is the vcpkg expected one:

$ sha512sum thrift-0.20.0.tar.gz 
5e4ee9870b30fe5ba484d39781c435716f7f3903793dc8aae96594ca813b1a5a73363b84719038ca8fa3ab8ef0a419a28410d936ff7b3bbadf36fc085a6883ae  thrift-0.20.0.tar.gz

@raulcd
Copy link
Member Author

raulcd commented Jul 10, 2024

The java-jars job is failing with the same issue on the aarch64 build:
https://github.com/ursacomputing/crossbow/actions/runs/9860012456/job/27257219621#step:8:4965
I am investigating if there is any issue on the k8s-cluster on the arm64 hosts

@raulcd
Copy link
Member Author

raulcd commented Jul 10, 2024

With the help from @midnattsol we have tried on the arm64 boxes:

[root@ip-10-20-24-127 ~]# curl --fail -L https://github.com/apache/thrift/archive/0.20.0.tar.gz --create-dirs --output /opt/vcpkg/downloads/apache-thrift-0.20.0.tar.gz.62659.part
[root@ip-10-20-24-127 ~]# sha512sum /opt/vcpkg/downloads/apache-thrift-0.20.0.tar.gz.62659.part
86a609f5725506abc2109902b338cbaad85abf980f9d28c63e6e50a5c265dc10699372c4e91f5ee85d8d09fbcbb0dc17c19745b86d215b96bbf7d0a9270f0932  /opt/vcpkg/downloads/apache-thrift-0.20.0.tar.gz.62659.part

and the sha is not the correct one.
The problem seems to be the https://github.com/apache/thrift/archive/0.20.0.tar.gz is wrong versus https://github.com/apache/thrift/archive/refs/tags/v0.20.0.tar.gz which is correct. I am not sure how to proceed at this point, maybe raise an issue on vcpkg?

@raulcd
Copy link
Member Author

raulcd commented Jul 10, 2024

This seems to be tracked here: microsoft/vcpkg#39786

@raulcd raulcd mentioned this issue Jul 10, 2024
Closed
raulcd added a commit to raulcd/arrow that referenced this issue Jul 10, 2024
@raulcd
apacheGH-43204: [CI][Packaging] Apply vcpkg patch to fix Thrift version
0600a39
@github-actions github-actions bot mentioned this issue Jul 10, 2024
Merged
@laurentgo laurentgo mentioned this issue Jul 10, 2024
Merged
kou pushed a commit that referenced this issue Jul 10, 2024
@raulcd
GH-43204: [CI][Packaging] Apply vcpkg patch to fix Thrift version (#4…
2ae192b 
…3208)

### Rationale for this change

Currently our java-jars and some wheels jobs are failing due to downloading a wrong version of Apache Thrift based on the 0.20.0 branch instead of the tag. That branch contains a new commit that makes the sha validation to fail.

### What changes are included in this PR?

Apply the Thrift patch that was applied on vcpkg here: microsoft/vcpkg#39787

### Are these changes tested?
Via archery

### Are there any user-facing changes?
No
* GitHub Issue: #43204

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member

kou commented Jul 10, 2024

Issue resolved by pull request 43208
#43208

@kou kou closed this as completed Jul 10, 2024
@vibhatha vibhatha mentioned this issue Jul 11, 2024
Merged
raulcd added a commit that referenced this issue Jul 11, 2024
@raulcd
GH-43204: [CI][Packaging] Apply vcpkg patch to fix Thrift version (#4…
bf75923 
…3208)

### Rationale for this change

Currently our java-jars and some wheels jobs are failing due to downloading a wrong version of Apache Thrift based on the 0.20.0 branch instead of the tag. That branch contains a new commit that makes the sha validation to fail.

### What changes are included in this PR?

Apply the Thrift patch that was applied on vcpkg here: microsoft/vcpkg#39787

### Are these changes tested?
Via archery

### Are there any user-facing changes?
No
* GitHub Issue: #43204

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Continuous Integration Component: Packaging Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@kou @raulcd