Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Java] Remove superfluous add-source execution #43216

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

laurentgo
Copy link
Collaborator

Rationale for this change

protobuf plugin already adds generated protobuf classes to the list of source directories, so remove the superfluous build-helper:add-source execution

Are these changes tested?

Yes via CI/CD

Are there any user-facing changes?

No

protobuf plugin already adds generated protobuf classes to the list of
source directories, so remove the superfluous build-helper:add-source
execution
@vibhatha
Copy link
Collaborator

@github-actions crossbow submit -g java

Copy link

Revision: f223537

Submitted crossbow builds: ursacomputing/crossbow @ actions-d29bec0db0

Task Status
java-jars GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@lidavidm lidavidm merged commit 797ca30 into apache:main Jul 11, 2024
16 checks passed
@lidavidm lidavidm removed the awaiting review Awaiting review label Jul 11, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 11, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 797ca30.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@laurentgo laurentgo deleted the laurentgo/remove-add-source-goal branch July 11, 2024 15:11
@vibhatha
Copy link
Collaborator

@github-actions crossbow submit -g java-jars

Copy link

Invalid group(s) {'java-jars'}. Must be one of {'verify-rc-source-linux', 'linux-amd64', 'nightly-tests', 'verify-rc', 'linux', 'verify-rc-source', 'go', 'homebrew', 'verify-rc-binaries', 'nightly', 'verify-rc-wheels', 'conan', 'example-python', 'ruby', 'example-cpp', 'java', 'conda', 'nightly-packaging', 'verify-rc-jars', 'fuzz', 'r', 'vcpkg', 'verify-rc-source-macos', 'linux-arm64', 'python', 'test', 'c-glib', 'integration', 'example', 'wheel', 'cpp', 'nightly-release', 'packaging'}
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/10085984066

@vibhatha
Copy link
Collaborator

@github-actions crossbow submit -g java java-jars

Copy link

Revision: f223537

Submitted crossbow builds: ursacomputing/crossbow @ actions-ba68e21443

Task Status
java-jars GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants