Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] vendored abseil fails to build with gcc-13 #43228

Closed
amol- opened this issue Jul 11, 2024 · 1 comment
Closed

[C++] vendored abseil fails to build with gcc-13 #43228

amol- opened this issue Jul 11, 2024 · 1 comment
Assignees
@amol-
Labels
Component: C++ Type: bug
Milestone
18.0.0

Comments

@amol-
Copy link
Member

amol- commented Jul 11, 2024

Describe the bug, including details regarding any error messages, version, and platform.

Currently Arrow fails to build on GCC-13 when compiling the "vendored" Abseil because the used version of Abseil doesn't compile on GCC 13 (was later fixed in abseil/abseil-cpp@b957f0c )

FormatConversionCharSetInternal::c;
      |             ^~~~~~~~~~~~~~~~~~~~~~~
/home/amol/ARROW/arrow/cpp/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.h:166:18: note: in expansion of macro ‘ABSL_INTERNAL_CHAR_SET_CASE’
  166 |   X_VAL(f) X_SEP X_VAL(F) X_SEP X_VAL(e) X_SEP X_VAL(E) X_SEP \
      |                  ^~~~~
/home/amol/ARROW/arrow/cpp/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:45:1: note: in expansion of macro ‘ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_’
   45 | ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_(ABSL_INTERNAL_CHAR_SET_CASE, )
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/amol/ARROW/arrow/cpp/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:44:13: error: ‘FormatConversionCharSet’ does not name a type; did you mean ‘FormatConversionCharInternal’?
   44 |   constexpr FormatConversionCharSet FormatConversionCharSetInternal::c;
      |             ^~~~~~~~~~~~~~~~~~~~~~~

Component(s)

C++
@amol- amol- mentioned this issue Jul 11, 2024
Merged
assignUser pushed a commit that referenced this issue Jul 26, 2024
@amol- @kou
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
aaeff72 
### Rationale for this change

When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.

There have been past reports for this issue too: #36969 

This is a more minimal fix that tries to avoid the complexity of previous attempts like  #43147 and #37066 which involved updating Abseil and facing additional issues to fix.

### What changes are included in this PR?

Add the missing include when GCC>=13

### Are these changes tested?

They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.

### Are there any user-facing changes?

No, all behaviours should remain the same
* GitHub Issue: #43228

Lead-authored-by: Alessandro Molina <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
@assignUser assignUser added this to the 18.0.0 milestone Jul 26, 2024
@assignUser
Copy link
Member

Issue resolved by pull request 43157
#43157

jonkeane pushed a commit that referenced this issue Jul 31, 2024
@amol- @kou @jonkeane
GH-43228: [C++] Fix Abseil compile error on GCC 13 (#43157)
cbd6b5c 
### Rationale for this change

When trying to compile Arrow with GCC 13, it fails due to ABSEIL missing a `<cstdint>` include, this PR addresses the issue by adding the missing include.

There have been past reports for this issue too: #36969 

This is a more minimal fix that tries to avoid the complexity of previous attempts like  #43147 and #37066 which involved updating Abseil and facing additional issues to fix.

### What changes are included in this PR?

Add the missing include when GCC>=13

### Are these changes tested?

They are tested by the existing compile infrastructure and testsuite and by adding a new GCC-13 based CPP test environment for bundled builds.

### Are there any user-facing changes?

No, all behaviours should remain the same
* GitHub Issue: #43228

Lead-authored-by: Alessandro Molina <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amol- amol-

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@amol- @assignUser