From 93de801dc787bb4e7027e66e88937eba7cfcdf8a Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Wed, 23 Aug 2023 14:50:48 -0400 Subject: [PATCH 1/9] Add Date32Type and DateType MATLAB classes. --- matlab/src/matlab/+arrow/+type/Date32Type.m | 33 +++++++++++++++ matlab/src/matlab/+arrow/+type/DateType.m | 45 +++++++++++++++++++++ 2 files changed, 78 insertions(+) create mode 100644 matlab/src/matlab/+arrow/+type/Date32Type.m create mode 100644 matlab/src/matlab/+arrow/+type/DateType.m diff --git a/matlab/src/matlab/+arrow/+type/Date32Type.m b/matlab/src/matlab/+arrow/+type/Date32Type.m new file mode 100644 index 0000000000000..8f0a2b1dc5cb0 --- /dev/null +++ b/matlab/src/matlab/+arrow/+type/Date32Type.m @@ -0,0 +1,33 @@ +%DATE32TYPE Type class for date32 data. + +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef Date32Type < arrow.type.DateType + + methods + + function obj = Date32Type(proxy) + arguments + proxy(1, 1) libmexclass.proxy.Proxy {validate(proxy, "arrow.type.proxy.Date32Type")} + end + import arrow.internal.proxy.validate + + obj@arrow.type.DateType(proxy); + end + + end + +end diff --git a/matlab/src/matlab/+arrow/+type/DateType.m b/matlab/src/matlab/+arrow/+type/DateType.m new file mode 100644 index 0000000000000..cd7de02c4d5d9 --- /dev/null +++ b/matlab/src/matlab/+arrow/+type/DateType.m @@ -0,0 +1,45 @@ +%DATETYPE Type class for date data. + +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef DateType < arrow.type.TemporalType + + properties(Dependent, SetAccess=private, GetAccess=public) + DateUnit + end + + methods + function obj = DateType(proxy) + arguments + proxy(1, 1) libmexclass.proxy.Proxy + end + obj@arrow.type.TemporalType(proxy); + end + + function dateUnit = get.DateUnit(obj) + dateUnitvalue = obj.Proxy.getDateUnit(); + dateUnit = arrow.type.TimeUnit(dateUnitvalue); + end + end + + methods (Access=protected) + function group = getPropertyGroups(~) + targets = ["ID" "DateUnit"]; + group = matlab.mixin.util.PropertyGroup(targets); + end + end + +end \ No newline at end of file From 74e4df542225c95f28dd688748904c4c75fea747 Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Wed, 23 Aug 2023 15:00:41 -0400 Subject: [PATCH 2/9] Add DateType C++ Proxy class. --- .../cpp/arrow/matlab/type/proxy/date_type.cc | 37 +++++++++++++++++++ .../cpp/arrow/matlab/type/proxy/date_type.h | 35 ++++++++++++++++++ 2 files changed, 72 insertions(+) create mode 100644 matlab/src/cpp/arrow/matlab/type/proxy/date_type.cc create mode 100644 matlab/src/cpp/arrow/matlab/type/proxy/date_type.h diff --git a/matlab/src/cpp/arrow/matlab/type/proxy/date_type.cc b/matlab/src/cpp/arrow/matlab/type/proxy/date_type.cc new file mode 100644 index 0000000000000..f87fca17e2970 --- /dev/null +++ b/matlab/src/cpp/arrow/matlab/type/proxy/date_type.cc @@ -0,0 +1,37 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/matlab/type/proxy/date_type.h" + +namespace arrow::matlab::type::proxy { + + DateType::DateType(std::shared_ptr date_type) : FixedWidthType(std::move(date_type)) { + REGISTER_METHOD(DateType, getDateUnit); + } + + void Datetype::getDateUnit(libmexclass::proxy::method::Context& context) { + namespace mda = ::matlab::data; + mda::ArrayFactory factory; + + auto date_type = std::static_pointer_cast(data_type); + const auto date_unit = date_type->unit(); + // Cast to uint8_t since there are only two supported DateUnit enumeration values: + // Day and Millisecond + auto date_unit_mda = factory.createScalar(static_cast(date_unit)); + context.outputs[0] = date_unit_mda; + } +} diff --git a/matlab/src/cpp/arrow/matlab/type/proxy/date_type.h b/matlab/src/cpp/arrow/matlab/type/proxy/date_type.h new file mode 100644 index 0000000000000..72c33751abca8 --- /dev/null +++ b/matlab/src/cpp/arrow/matlab/type/proxy/date_type.h @@ -0,0 +1,35 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "arrow/matlab/type/proxy/fixed_width_type.h" + +namespace arrow::matlab::type::proxy { + +class DateType : public arrow::matlab::type::proxy::FixedWidthType { + + public: + DateType(std::shared_ptr date_type); + + ~DateType() {} + + protected: + void getDateUnit(libmexclass::proxy::method::Context& context); +}; + +} From 2f1813422ad3128a55e92b116db4e46718708de1 Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Wed, 23 Aug 2023 15:10:49 -0400 Subject: [PATCH 3/9] Add Date32 C++ Proxy class. --- .../arrow/matlab/type/proxy/date32_type.cc | 34 ++++++++++++++++++ .../cpp/arrow/matlab/type/proxy/date32_type.h | 36 +++++++++++++++++++ .../cmake/BuildMatlabArrowInterface.cmake | 2 ++ 3 files changed, 72 insertions(+) create mode 100644 matlab/src/cpp/arrow/matlab/type/proxy/date32_type.cc create mode 100644 matlab/src/cpp/arrow/matlab/type/proxy/date32_type.h diff --git a/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.cc b/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.cc new file mode 100644 index 0000000000000..f74038cddaac0 --- /dev/null +++ b/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.cc @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/matlab/type/proxy/date32_type.h" +#include "arrow/matlab/error/error.h" +#include "arrow/util/utf8.h" + +namespace arrow::matlab::type::proxy { + + Date32Type::Date32Type(std::shared_ptr date32_type) : DateType(std::move(date32_type)) {} + + libmexclass::proxy::MakeResult Date32Type::make(const libmexclass::proxy::FunctionArguments& constructor_arguments) { + namespace mda = ::matlab::data; + using Date32TypeProxy = arrow::matlab::type::proxy::Date32Type; + + const auto type = arrow::date32(); + const auto date32_type = std::static_pointer_cast(type); + return std::make_shared(std::move(date32_type)); + } +} diff --git a/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.h b/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.h new file mode 100644 index 0000000000000..a239d4e6b45ca --- /dev/null +++ b/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.h @@ -0,0 +1,36 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "arrow/matlab/type/proxy/date_type.h" + +namespace arrow::matlab::type::proxy { + + class Date32Type : public arrow::matlab::type::proxy::DateType { + + public: + Date32Type(std::shared_ptr date32_type); + + ~Date32Type() {} + + static libmexclass::proxy::MakeResult make(const libmexclass::proxy::FunctionArguments& constructor_arguments); + + }; + +} + diff --git a/matlab/tools/cmake/BuildMatlabArrowInterface.cmake b/matlab/tools/cmake/BuildMatlabArrowInterface.cmake index 477d7e6724d5a..306ffa7debb2a 100644 --- a/matlab/tools/cmake/BuildMatlabArrowInterface.cmake +++ b/matlab/tools/cmake/BuildMatlabArrowInterface.cmake @@ -55,6 +55,8 @@ set(MATLAB_ARROW_LIBMEXCLASS_CLIENT_PROXY_SOURCES "${CMAKE_SOURCE_DIR}/src/cpp/a "${CMAKE_SOURCE_DIR}/src/cpp/arrow/matlab/type/proxy/type.cc" "${CMAKE_SOURCE_DIR}/src/cpp/arrow/matlab/type/proxy/fixed_width_type.cc" "${CMAKE_SOURCE_DIR}/src/cpp/arrow/matlab/type/proxy/string_type.cc" + "${CMAKE_SOURCE_DIR}/src/cpp/arrow/matlab/type/proxy/date_type.cc" + "${CMAKE_SOURCE_DIR}/src/cpp/arrow/matlab/type/proxy/date32_type.cc" "${CMAKE_SOURCE_DIR}/src/cpp/arrow/matlab/type/proxy/timestamp_type.cc" "${CMAKE_SOURCE_DIR}/src/cpp/arrow/matlab/type/proxy/time_type.cc" "${CMAKE_SOURCE_DIR}/src/cpp/arrow/matlab/type/proxy/time32_type.cc" From 5ca099930d5a85a59f313413fd8b5eef70726050 Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Wed, 23 Aug 2023 15:19:15 -0400 Subject: [PATCH 4/9] Fix typo. Capitalize DateType. --- matlab/src/cpp/arrow/matlab/type/proxy/date_type.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/matlab/src/cpp/arrow/matlab/type/proxy/date_type.cc b/matlab/src/cpp/arrow/matlab/type/proxy/date_type.cc index f87fca17e2970..25b639f8477ed 100644 --- a/matlab/src/cpp/arrow/matlab/type/proxy/date_type.cc +++ b/matlab/src/cpp/arrow/matlab/type/proxy/date_type.cc @@ -23,7 +23,7 @@ namespace arrow::matlab::type::proxy { REGISTER_METHOD(DateType, getDateUnit); } - void Datetype::getDateUnit(libmexclass::proxy::method::Context& context) { + void DateType::getDateUnit(libmexclass::proxy::method::Context& context) { namespace mda = ::matlab::data; mda::ArrayFactory factory; From b9115f462a410e4693b2affb5581b46c9eca0431 Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Wed, 23 Aug 2023 15:19:36 -0400 Subject: [PATCH 5/9] Add `arrow.date32` construction function. --- matlab/src/matlab/+arrow/date32.m | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 matlab/src/matlab/+arrow/date32.m diff --git a/matlab/src/matlab/+arrow/date32.m b/matlab/src/matlab/+arrow/date32.m new file mode 100644 index 0000000000000..a64cb7c419051 --- /dev/null +++ b/matlab/src/matlab/+arrow/date32.m @@ -0,0 +1,20 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +function type = date32() +%DATE32 Creates an arrow.type.Date32Type object + proxy = arrow.internal.proxy.create("arrow.type.proxy.Date32Type"); + type = arrow.type.Date32Type(proxy); +end From 0b84e06c41c12447788b8f78d09a14747f5f1bdc Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Wed, 23 Aug 2023 15:21:11 -0400 Subject: [PATCH 6/9] Register Date32Type Proxy. --- matlab/src/cpp/arrow/matlab/proxy/factory.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/matlab/src/cpp/arrow/matlab/proxy/factory.cc b/matlab/src/cpp/arrow/matlab/proxy/factory.cc index 554046f600abc..93dd9245aeb3c 100644 --- a/matlab/src/cpp/arrow/matlab/proxy/factory.cc +++ b/matlab/src/cpp/arrow/matlab/proxy/factory.cc @@ -26,6 +26,7 @@ #include "arrow/matlab/type/proxy/primitive_ctype.h" #include "arrow/matlab/type/proxy/string_type.h" #include "arrow/matlab/type/proxy/timestamp_type.h" +#include "arrow/matlab/type/proxy/date32_type.h" #include "arrow/matlab/type/proxy/time32_type.h" #include "arrow/matlab/type/proxy/time64_type.h" #include "arrow/matlab/type/proxy/field.h" @@ -67,8 +68,9 @@ libmexclass::proxy::MakeResult Factory::make_proxy(const ClassName& class_name, REGISTER_PROXY(arrow.type.proxy.BooleanType , arrow::matlab::type::proxy::PrimitiveCType); REGISTER_PROXY(arrow.type.proxy.StringType , arrow::matlab::type::proxy::StringType); REGISTER_PROXY(arrow.type.proxy.TimestampType , arrow::matlab::type::proxy::TimestampType); - REGISTER_PROXY(arrow.type.proxy.Time64Type , arrow::matlab::type::proxy::Time64Type); REGISTER_PROXY(arrow.type.proxy.Time32Type , arrow::matlab::type::proxy::Time32Type); + REGISTER_PROXY(arrow.type.proxy.Time64Type , arrow::matlab::type::proxy::Time64Type); + REGISTER_PROXY(arrow.type.proxy.Date32Type , arrow::matlab::type::proxy::Date32Type); REGISTER_PROXY(arrow.io.feather.proxy.Writer , arrow::matlab::io::feather::proxy::Writer); REGISTER_PROXY(arrow.io.feather.proxy.Reader , arrow::matlab::io::feather::proxy::Reader); From 8233a9fb61683e03abf77d6fa1bf0e0e5208d00e Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Wed, 23 Aug 2023 15:22:44 -0400 Subject: [PATCH 7/9] Fix typo. TimeUnit -> DateUnit. --- matlab/src/matlab/+arrow/+type/DateType.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/matlab/src/matlab/+arrow/+type/DateType.m b/matlab/src/matlab/+arrow/+type/DateType.m index cd7de02c4d5d9..f8a3966602e12 100644 --- a/matlab/src/matlab/+arrow/+type/DateType.m +++ b/matlab/src/matlab/+arrow/+type/DateType.m @@ -31,7 +31,7 @@ function dateUnit = get.DateUnit(obj) dateUnitvalue = obj.Proxy.getDateUnit(); - dateUnit = arrow.type.TimeUnit(dateUnitvalue); + dateUnit = arrow.type.DateUnit(dateUnitvalue); end end @@ -42,4 +42,4 @@ end end -end \ No newline at end of file +end From e066cef11039749bc01bd8ed97342e7cf2359cd5 Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Wed, 23 Aug 2023 15:46:24 -0400 Subject: [PATCH 8/9] 1. Add tests for arrow.type.Date32Type and arrow.date32. 2. Add arrow.type.ID.Date32 type enumeration. --- matlab/src/matlab/+arrow/+type/ID.m | 2 +- matlab/test/arrow/type/tDate32Type.m | 81 ++++++++++++++++++++++++++++ matlab/test/arrow/type/tID.m | 1 + 3 files changed, 83 insertions(+), 1 deletion(-) create mode 100644 matlab/test/arrow/type/tDate32Type.m diff --git a/matlab/src/matlab/+arrow/+type/ID.m b/matlab/src/matlab/+arrow/+type/ID.m index e5b53cfa655bf..66ea3a5c7f750 100644 --- a/matlab/src/matlab/+arrow/+type/ID.m +++ b/matlab/src/matlab/+arrow/+type/ID.m @@ -32,7 +32,7 @@ String (13) % Binary (14) % FixedSizeBinary (15) - % Date32 (16) + Date32 (16) % Date64 (17) Timestamp (18) Time32 (19) diff --git a/matlab/test/arrow/type/tDate32Type.m b/matlab/test/arrow/type/tDate32Type.m new file mode 100644 index 0000000000000..984baa66bbda1 --- /dev/null +++ b/matlab/test/arrow/type/tDate32Type.m @@ -0,0 +1,81 @@ +% Licensed to the Apache Software Foundation (ASF) under one or more +% contributor license agreements. See the NOTICE file distributed with +% this work for additional information regarding copyright ownership. +% The ASF licenses this file to you under the Apache License, Version +% 2.0 (the "License"); you may not use this file except in compliance +% with the License. You may obtain a copy of the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, +% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or +% implied. See the License for the specific language governing +% permissions and limitations under the License. + +classdef tDate32Type < hFixedWidthType +% Test class for arrow.type.Date32Type and arrow.date32 + + properties + ConstructionFcn = @arrow.date32 + ArrowType = arrow.date32 + TypeID = arrow.type.ID.Date32 + BitWidth = int32(32) + ClassName = "arrow.type.Date32Type" + end + + methods(Test) + function TestClass(testCase) + % Verify ArrowType is an object of the expected class type. + name = string(class(testCase.ArrowType)); + testCase.verifyEqual(name, testCase.ClassName); + end + + function DefaultDateUnit(testCase) + % Verify the default DateUnit is Day. + type = testCase.ArrowType; + actualUnit = type.DateUnit; + expectedUnit = arrow.type.DateUnit.Day; + testCase.verifyEqual(actualUnit, expectedUnit); + end + + function Display(testCase) + % Verify the display of Date32Type objects. + % + % Example: + % + % Date32Type with properties: + % + % ID: Date32 + % DateUnit: Day + % + type = testCase.ConstructionFcn(); %#ok + classnameLink = "Date32Type"; + header = " " + classnameLink + " with properties:" + newline; + body = strjust(pad(["ID:"; "DateUnit:"])); + body = body + " " + ["Date32"; "Day"]; + body = " " + body; + footer = string(newline); + expectedDisplay = char(strjoin([header body' footer], newline)); + actualDisplay = evalc('disp(type)'); + testCase.verifyEqual(actualDisplay, expectedDisplay); + end + + function DateUnitNoSetter(testCase) + % Verify that an error is thrown when trying to set the value + % of the DateUnit property. + type = arrow.date32(); + testCase.verifyError(@() setfield(type, "DateUnit", "Millisecond"), "MATLAB:class:SetProhibited"); + end + + function InvalidProxy(testCase) + % Verify that an error is thrown when a Proxy of an unexpected + % type is passed to the arrow.type.Date32Type constructor. + array = arrow.array([1, 2, 3]); + proxy = array.Proxy; + testCase.verifyError(@() arrow.type.Date32Type(proxy), "arrow:proxy:ProxyNameMismatch"); + end + + end + +end diff --git a/matlab/test/arrow/type/tID.m b/matlab/test/arrow/type/tID.m index f0014718e3a50..d83bb4475feff 100644 --- a/matlab/test/arrow/type/tID.m +++ b/matlab/test/arrow/type/tID.m @@ -42,6 +42,7 @@ function CastToUInt64(testCase) ID.Float32, 11, ... ID.Float64, 12, ... ID.String, 13, ... + ID.Date32, 16, ... ID.Timestamp, 18, ... ID.Time32, 19, ... ID.Time64, 20 ... From 61bbb3787bc72ca1659901373b07e9712eb425a2 Mon Sep 17 00:00:00 2001 From: Kevin Gurney Date: Wed, 23 Aug 2023 16:44:16 -0400 Subject: [PATCH 9/9] Address code review feedback. Remove unused header includes and unused namespace alias. Co-authored-by: Sarah Gilmore --- matlab/src/cpp/arrow/matlab/type/proxy/date32_type.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.cc b/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.cc index f74038cddaac0..c699c121efc1b 100644 --- a/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.cc +++ b/matlab/src/cpp/arrow/matlab/type/proxy/date32_type.cc @@ -16,15 +16,12 @@ // under the License. #include "arrow/matlab/type/proxy/date32_type.h" -#include "arrow/matlab/error/error.h" -#include "arrow/util/utf8.h" namespace arrow::matlab::type::proxy { Date32Type::Date32Type(std::shared_ptr date32_type) : DateType(std::move(date32_type)) {} libmexclass::proxy::MakeResult Date32Type::make(const libmexclass::proxy::FunctionArguments& constructor_arguments) { - namespace mda = ::matlab::data; using Date32TypeProxy = arrow::matlab::type::proxy::Date32Type; const auto type = arrow::date32();