CASSGO-48 Bump actions/upload-artifact and actions/cache versions to v4 #1861
Conversation
|
I bumped the version of @joao-r-reis Could you please look at this one? Also, I noticed warnings about deprecation of |
worryg0d
changed the title
.github/workflows/main.yml
Outdated
| - name: 'Save ccm logs' | ||
| if: 'failure()' | ||
| uses: actions/upload-artifact@v3 | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ccm-cluster | ||
| path: /home/runner/.ccm/test |
There was a problem hiding this comment.
There are breaking changes in version 4.
The actions/upload-artifact documentation states that artifacts are immutable, and you can no longer upload to the same artifact name multiple times. It should be either upload to multiple artifacts with different names or upload everything at once. Otherwise, you will encounter an error.
Since this job uses a matrix, and judging by the documentation and current implementation, it could lead to errors if multiple matrix jobs fail.
There was a problem hiding this comment.
Oh, I see the issue here. I tested it on my fork forcing the workflow to fail and it really doesn't upload the artifacts...
Run actions/upload-artifact@v4
With the provided path, there will be 922 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
I'm going to work on a fix for this. Thanks a lot!
There was a problem hiding this comment.
Fixed by constructing the name of the artifact using variables from the matrix:
ccm-cluster-cassandra-${{ matrix.cassandra_version }}-go-${{ matrix.go }}-tag-${{ matrix.tags }}
I was about to add matrix.compressor as well, but we have only snappy in the matrix and #1567 is not merged yet.
If anybody has concerns about this, please feel free to discuss it here.
There was a problem hiding this comment.
I'm fine with not adding matrix.compressor here but we have to remember to do it in #1567
There was a problem hiding this comment.
Yeah I was thinking of #1842 too my bad
It should be safe to bump from actions/cache@v2 to actions/cache@v4, and doing so is recommended to stay current with the latest improvements and avoid issues like the one experienced by @worryg0d. I ran the job using the current code (which still uses deprecated action versions) and did not encounter any CI cancellations. However, there are ongoing discussions about sunsetting older versions, as highlighted in this GitHub discussion and this deprecation notice. |
By the current code do you mean the code from this PR? If so, I didn't encounter any issues with However, as you said, it will be sunsetted soon |
|
If bumping |
|
In the discussion highlited: So it looks like there are no problems with bumping it too |
Nice, feel free to go for it and update the JIRA, PR title and commit message and then I'll merge this |
worryg0d
changed the title
|
Bumped actions/cache to v4 as well. @joao-r-reis could you please approve the workflow run? Thanks! |
Bumped due to cancelation of running CI workflows with the deprecated version of actions/upload-artifact@v3 and in order to prevent future interruptions with deprecation of actions/cache@v2. Patch by Bohdan Siryk; Reviewed by João Reis, Stanislav Bychkov for CASSGO-48
Bumped due to cancelation of running CI workflows with the deprecated version of actions/upload-artifact@v3 and in order to prevent future interruptions with deprecation of actions/cache@v2.
Patch by Bohdan Siryk; Reviewed by João Reis, Stanislav Bychkov for CASSGO-48