-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datafusion Query Planning tests in CI #9
Comments
At the moment, we already run some query planning tests, see https://github.com/edmondop/datafusion-ray/actions/runs/11133252895/job/30938921925 |
These tests do not actually do anything currently, unless they run on my computer 😞 async fn do_test(n: u8) -> Result<()> {
let data_path = "/mnt/bigdata/tpch/sf10-parquet";
if !Path::new(&data_path).exists() {
return Ok(());
} |
We have a Python script at https://github.com/apache/datafusion-benchmarks/tree/main/tpch for generating TPC-H data: https://github.com/apache/datafusion-benchmarks/tree/main/tpch We could call this in CI and then figure out how to update theses tests to use that data |
Excellent, I'll do this as a first iteration, thank for the hint. Then we can decide how to do the comparison between datafusion results and ray results, what do you think? |
Sounds good. We could run each query first with DF Python and then with DF Ray and compare the results. This could be a good general approach to testing. |
Quoting @andygrove on Discord:
The text was updated successfully, but these errors were encountered: