Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Sort Merge Join algorithm #10357

Open
Tracked by #9846
comphead opened this issue May 2, 2024 · 5 comments · May be fixed by #13469
Open
Tracked by #9846

Document Sort Merge Join algorithm #10357

comphead opened this issue May 2, 2024 · 5 comments · May be fixed by #13469
Assignees
@athultr1997
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@comphead
Copy link
Contributor

comphead commented May 2, 2024 •
edited
Loading

Is your feature request related to a problem or challenge?

I faced that it is challenging to understand fully how Sort Merge Join sort_merge_join.rs implemented and would be nice to get it documented the same way as HashJoin in hash_join.rs

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@comphead comphead added documentation Improvements or additions to documentation enhancement New feature or request labels May 2, 2024
@comphead
Copy link
Contributor Author

comphead commented May 2, 2024

Found when fixing SMJ bugs #10304

@comphead
Copy link
Contributor Author

comphead commented May 2, 2024

cc @korowa you might be interested

@alamb
Copy link
Contributor

alamb commented May 2, 2024

Maybe @metesynnada can help remember who knows about this code too

@viirya
Copy link
Member

viirya commented May 2, 2024

I spent some time reading and understanding the code last time I worked with it. I may try to document it some once I get time to refresh it...

@comphead comphead mentioned this issue May 4, 2024
Open
18 tasks
@comphead comphead mentioned this issue Aug 21, 2024
Closed
@athultr1997
Copy link
Contributor

take

@athultr1997 athultr1997 linked a pull request Nov 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athultr1997 athultr1997

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added documentation for SortMergeJoin athultr1997/datafusion
4 participants
@viirya @alamb @comphead @athultr1997