Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][etcd] Distinguish between add and update by using pre kv #14658

Closed
3 tasks done
eye-gu opened this issue Jul 29, 2023 · 0 comments · Fixed by #14659
Closed
3 tasks done

[Improvement][etcd] Distinguish between add and update by using pre kv #14658

eye-gu opened this issue Jul 29, 2023 · 0 comments · Fixed by #14659
Assignees
Labels
improvement make more easy to user or prompt friendly

Comments

@eye-gu
Copy link
Contributor

eye-gu commented Jul 29, 2023

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

When using ETCD as the registry, each heartbeat task is considered an add event. This can lead to some misunderstandings. Add and update should be distinguished by whether there is a pre kv

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants