Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] [Helm] bitnami/postgresql sub chart and default configurations should be upgraded #14672

Closed
2 of 3 tasks
icefery opened this issue Jul 31, 2023 · 2 comments
Closed
2 of 3 tasks
Labels
help wanted Extra attention is needed improvement make more easy to user or prompt friendly kubernetes Stale

Comments

@icefery
Copy link

icefery commented Jul 31, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

For the chart dolphinscheduler-helm-3.1.7, sub chart bitnami/postgresql-10.3.18(default docker images) is incompatible with arm64.

When upgrading the bitnami/postgresql sub chart version, its configurations have changed, in order to get it working, there are some changes:

  • Chart.yaml

    dependencies:
    - name: postgresql
      version: 12.7.1
      repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
      condition: postgresql.enabled
  • values.yaml

    postgresql:
      enabled: true
      global:
        postgresql:
          auth:
            postgresPassword: postgres
            username: dolphinscheduler
            password: dolphinscheduler
            database: dolphinscheduler
  • templates/_helpers.tpl

    - name: SPRING_DATASOURCE_USERNAME
      {{- if .Values.postgresql.enabled }}
      value: {{ .Values.postgresql.global.postgresql.auth.username }}
      {{- end }}
    - name: SPRING_DATASOURCE_PASSWORD
      valueFrom:
        secretKeyRef:
          {{- if .Values.postgresql.enabled }}
          name: {{ template "dolphinscheduler.postgresql.fullname" . }}
          key: password
          {{- end }}
    {{- end -}}

What you expected to happen

The version of sub charts are newer, and compatible with default Chart.yaml, values.yaml, 'templates/*'.

How to reproduce

See 'What happened'.

Anything else

No response

Version

3.1.x

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@icefery icefery added bug Something isn't working Waiting for reply Waiting for reply labels Jul 31, 2023
@SbloodyS SbloodyS added help wanted Extra attention is needed improvement make more easy to user or prompt friendly kubernetes and removed bug Something isn't working Waiting for reply Waiting for reply labels Aug 7, 2023
@SbloodyS SbloodyS changed the title [Bug] [Helm] bitnami/postgresql sub chart and default configurations should be upgraded [Improvement] [Helm] bitnami/postgresql sub chart and default configurations should be upgraded Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Sep 7, 2023
@github-actions
Copy link

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed improvement make more easy to user or prompt friendly kubernetes Stale
Projects
None yet
Development

No branches or pull requests

2 participants