Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][security] get-user-info API endpoint should not return the user's password in MD5 format #14679

Closed
3 tasks done
Gallardot opened this issue Aug 1, 2023 · 0 comments · Fixed by #14680
Closed
3 tasks done
Assignees
Labels
improvement make more easy to user or prompt friendly

Comments

@Gallardot
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

The get-user-info API endpoint currently returns the user's password in MD5 format, which is then stored in the local storage by the web front-end.

public Result getUserInfo(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser) {
Map<String, Object> result = usersService.getUserInfo(loginUser);
return returnDataList(result);
}

const userInfoRes: UserInfoRes = await getUserInfo()
await userStore.setUserInfo(userInfoRes)

However, there is no functionality that requires the use of this password. Moreover, this password is just a simple MD5 hash, which can be easily cracked.

Therefore, I believe that get-user-info API endpoint should not return the password in MD5 format.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly
Projects
None yet
2 participants