Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [master] On the problem of repeated scheduling of dolphins #15323

Closed
2 of 3 tasks
LinYuHeng-Con opened this issue Dec 15, 2023 · 5 comments
Closed
2 of 3 tasks

[Bug] [master] On the problem of repeated scheduling of dolphins #15323

LinYuHeng-Con opened this issue Dec 15, 2023 · 5 comments
Labels
bug Something isn't working need to verify Stale

Comments

@LinYuHeng-Con
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

Dolphins experience repeated scheduling

What you expected to happen

Schedule only once

How to reproduce

Accidental appearance,At present, the production tasks are basically scheduled repeatedly every day

Anything else

image
image
image
image
image
image

Currently, dolphins use the LocalDataSourceJobStore class, but due to setDontSetAutoCommitFalse (true), autocommit is enabled, transactions are not enabled, and distributed locks are not effective

I plan to modify the LocalDataSourceJobStore in the configuration file to JobStoreCMT, or customize a JobStore to see the effect

Version

3.1.x

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@LinYuHeng-Con LinYuHeng-Con added bug Something isn't working Waiting for reply Waiting for reply labels Dec 15, 2023
@SbloodyS
Copy link
Member

SbloodyS commented Jan 3, 2024

Would you like to submit a pr to fix this? @LinYuHeng-Con

@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label Jan 3, 2024
@LinYuHeng-Con
Copy link
Author

Would you like to submit a pr to fix this? @LinYuHeng-Con

Let me roughly describe the problem of repeated scheduling before,

  1. As Tidb also supports the MySQL protocol, the data of Dolphinscheduler was previously stored in Tidb, resulting in duplicate scheduling issues

  2. So we consider whether the duplicate scheduling problem is caused by Tidb, as Tidb is a distributed database, and we plan to switch Tidb to MySQL

  3. However, before switching, I discovered the aforementioned issues and customized a JobStore, but there were still issues with duplicate scheduling

  4. So we switched Tidb directly to MySQL, and the configuration still used org. springframework. scheduling. quartz. LocalDataSourceJobStore

  5. The problem of repeated scheduling did not occur again afterwards

  6. At present, I am unable to determine whether it is due to the database or the code. I believe that there is a problem with the logic of obtaining distributed locks, but in reality, the problem of duplicate scheduling has not occurred again

@SbloodyS
Copy link
Member

SbloodyS commented Jan 3, 2024

Thanks for clearifying. You can ping me when you have new discoveries. @LinYuHeng-Con

Copy link

github-actions bot commented Feb 3, 2024

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Feb 3, 2024
Copy link

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need to verify Stale
Projects
None yet
Development

No branches or pull requests

2 participants