Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [SQL Task]Remove trailing semicolons from a SQL sentence. #15374

Closed
3 tasks done
iamcaoxudong opened this issue Dec 28, 2023 · 1 comment
Closed
3 tasks done

[Bug] [SQL Task]Remove trailing semicolons from a SQL sentence. #15374

iamcaoxudong opened this issue Dec 28, 2023 · 1 comment
Assignees
Labels
bug Something isn't working Waiting for user feedback Waiting for feedback from issue/PR author wontfix This will not be worked on

Comments

@iamcaoxudong
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

If a SQL task only has one SQL sentence, then this line will not ended with a ";/n" or ";/r/n". Instead it just has a trailing ";". In this case we need to manually remove the trailing ";", or it may cause a syntax error in some JDBC implementations (e.g. Hive JDBC).

What you expected to happen

If a SQL task only contains one single line, then we need to manully remove the trailing ";"

How to reproduce

  1. Create a SQL task that has only one line
    V3dQIH2aYv

  2. Run this task, then we can see a syntax error in som JDBC implementations (below is the HIVE case)
    VcwhoU8ZMd

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ruanwenjun
Copy link
Member

If you only have one sql, you should remove the ; here.

@ruanwenjun ruanwenjun added the wontfix This will not be worked on label Jan 4, 2024
@ruanwenjun ruanwenjun added the Waiting for reply Waiting for reply label Jan 30, 2024
@ruanwenjun ruanwenjun added Waiting for user feedback Waiting for feedback from issue/PR author and removed Waiting for reply Waiting for reply labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Waiting for user feedback Waiting for feedback from issue/PR author wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants