Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [UI] Projects] Custom parameters do not trigger validation when the added number during task created is greater than 2 #15429

Closed
2 of 3 tasks
JeremyXin opened this issue Jan 4, 2024 · 2 comments
Labels
bug Something isn't working Stale

Comments

@JeremyXin
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

When i try to create a Task Definition as Batch Task or create a Workflow Definition as SQL, i found that the custom parameter module could not trigger the validator in some situation. The condition as below

What you expected to happen

In normal case, the custom parameter module would verify that whether duplicate values exist in prop property values. If so, it would prompt: prop is repeat. When the creation task is performed, the custom parameter form appears fine, as below screenshot, but when the task is modified, some unexpected problems occur.
situation 0

Situation 1:
If the number of custom parameters added during task creation is greater than two, the validator verification would not be performed when the custom parameters are added. The screenshot is as follows:
situation1

and the save operation could be performed.

Also, When adding the custom parameter, if the prop property is the same as the first prop value, it would prompt the message: prop is repeat.
situation2

Situation 2:
If the number of custom parameters added during task creation is less than two, the validator verification would be performed fine. the situation is as follows:
situation 3

How to reproduce

According to the above description and screenshots can be reproduced

Anything else

No response

Version

3.1.x

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@JeremyXin JeremyXin added bug Something isn't working Waiting for reply Waiting for reply labels Jan 4, 2024
@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label Jul 17, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Aug 29, 2024
Copy link

github-actions bot commented Sep 5, 2024

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants