Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][shell_task] Shell task to have Workflow instance specific attributes for the use #15690

Closed
3 tasks done
baratamavinash225 opened this issue Mar 10, 2024 · 3 comments
Assignees
Labels
improvement make more easy to user or prompt friendly Stale

Comments

@baratamavinash225
Copy link

baratamavinash225 commented Mar 10, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

What happened
I would like to extend the shell task to have default variables of WORKFLOW_NAME, WORKFLOW_INSTANCE_NAME, WORKFLOW_ID, WORKFLOW_INSTANCE_ID
These variables can be used to track the logs, or use it for the external loggings such as splunk etc.,

What you expected to happen
DolphinScheduler ShellTask to return with the WORKFLOW_NAME, WORKFLOW_INSTANCE_NAME, WORKFLOW_ID, WORKFLOW_INSTANCE_ID when the user performs or uses these variables in the script.
ex: echo ${WORKFLOW_NAME} echo ${WORKFLOW_ID} echo ${WORKFLOW_INSTANCE_NAME} echo ${WORKFLOW_INSTANCE_ID} - should return the respective values pertained to the instance while running.

How to reproduce
Echo these variables post implementation to print the variables
echo ${WORKFLOW_NAME} echo ${WORKFLOW_ID} echo ${WORKFLOW_INSTANCE_NAME} echo ${WORKFLOW_INSTANCE_ID}

Anything else
No response

Version
3.1.x

Are you willing to submit PR?
Yes I am willing to submit a PR!
Code of Conduct
I agree to follow this project's Code of Conduct

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@baratamavinash225 baratamavinash225 added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Mar 10, 2024
@baratamavinash225
Copy link
Author

I am currently working on this item and submit the PR in a while

Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Apr 12, 2024
Copy link

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly Stale
Projects
None yet
Development

No branches or pull requests

2 participants