Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [WorkerGroupChangeNotifier] work group listeners may can not be triggered when cluster changed #16793

Open
3 tasks done
reele opened this issue Nov 12, 2024 · 0 comments · May be fixed by #16796
Open
3 tasks done

[Bug] [WorkerGroupChangeNotifier] work group listeners may can not be triggered when cluster changed #16793

reele opened this issue Nov 12, 2024 · 0 comments · May be fixed by #16796
Assignees
@reele
Labels
backend bug Something isn't working

Comments

@reele
Copy link
Contributor

reele commented Nov 12, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

  1. when the listeners is empty, detectWorkerGroupChanges() may execute at least 1 time, so when next time detectWorkerGroupChanges() executing, mapComparator.getValuesToAdd() can not get the group differences again.

  2. DEFAULT_REFRESH_WORKER_INTERVAL is too big, it will wait a long long time to detect again.

What you expected to happen

when the listeners is empty, mapComparator should always keeps the differences.

How to reproduce

create another worker group, start master-server

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reele reele

Labels
backend bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@SbloodyS @reele