Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [Master] Fix AbstractDelayEvent compare method is incorrect #16978

Open
2 of 3 tasks
ruanwenjun opened this issue Jan 23, 2025 · 1 comment · May be fixed by #16980
Open
2 of 3 tasks

[Bug] [Master] Fix AbstractDelayEvent compare method is incorrect #16978

ruanwenjun opened this issue Jan 23, 2025 · 1 comment · May be fixed by #16980
Labels
3.3.0 bug Something isn't working priority:high
Milestone
3.3.0

Comments

@ruanwenjun
Copy link
Member

ruanwenjun commented Jan 23, 2025 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

#16976 (comment)

What you expected to happen

If the event is not expired then should use exipre time to compare them, if the event is already expired then should use create time to compare them.

How to reproduce

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@ruanwenjun ruanwenjun added bug Something isn't working Waiting for reply Waiting for reply priority:high 3.3.0 and removed Waiting for reply Waiting for reply labels Jan 23, 2025
@ruanwenjun ruanwenjun added this to the 3.3.0 milestone Jan 23, 2025
@ruanwenjun
Copy link
Member Author

@reele

reele pushed a commit to reele/dolphinscheduler that referenced this issue Jan 23, 2025
Fix apache#16978 AbstractDelayEvent compare method is incorrect
82279d0
reele pushed a commit to reele/dolphinscheduler that referenced this issue Jan 23, 2025
Fix apache#16978 AbstractDelayEvent compare method is incorrect
8ee1049
reele pushed a commit to reele/dolphinscheduler that referenced this issue Jan 23, 2025
Fix apache#16978 AbstractDelayEvent compare method is incorrect
d9baca0
@reele reele linked a pull request Jan 23, 2025 that will close this issue
Open
reele pushed a commit to reele/dolphinscheduler that referenced this issue Jan 23, 2025
Fix apache#16978 AbstractDelayEvent compare method is incorrect-fix C…
7bf71e8 
…odeQL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.3.0 bug Something isn't working priority:high
Projects
None yet
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

[Fix-16978][Master] Fix AbstractDelayEvent compare method is incorrect reele/dolphinscheduler
1 participant
@ruanwenjun