Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](fix) fix the broadcast cause result error #47476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HappenLee
Copy link
Contributor

What problem does this PR solve?

shuffle may cause the _last_local_channel_idx set a error result

Multi BE trigger the bug

Release note

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32147 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c63f7a21d7cb37c244962076cc369b41d3b81377, data reload: false

------ Round 1 ----------------------------------
q1	17574	5499	5344	5344
q2	2042	305	167	167
q3	10425	1214	731	731
q4	10239	967	543	543
q5	8045	2390	2151	2151
q6	199	170	135	135
q7	899	759	599	599
q8	9228	1364	1169	1169
q9	5199	4907	4875	4875
q10	6843	2338	1892	1892
q11	482	280	255	255
q12	340	352	217	217
q13	17758	3699	3072	3072
q14	242	234	221	221
q15	515	466	469	466
q16	624	608	592	592
q17	564	864	320	320
q18	6799	6403	6312	6312
q19	1892	977	546	546
q20	316	318	187	187
q21	2812	2294	2052	2052
q22	367	339	301	301
Total cold run time: 103404 ms
Total hot run time: 32147 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5557	5508	5538	5508
q2	240	330	235	235
q3	2283	2636	2331	2331
q4	1419	1803	1383	1383
q5	4327	4699	4676	4676
q6	168	157	125	125
q7	2065	1989	1809	1809
q8	2629	2793	2704	2704
q9	7329	7255	7242	7242
q10	3061	3272	2822	2822
q11	582	519	477	477
q12	649	710	588	588
q13	3596	3953	3323	3323
q14	300	319	265	265
q15	518	487	471	471
q16	681	689	639	639
q17	1241	1736	1259	1259
q18	7731	7530	7387	7387
q19	784	1159	1072	1072
q20	1987	2054	1935	1935
q21	5794	5085	4962	4962
q22	646	604	566	566
Total cold run time: 53587 ms
Total hot run time: 51779 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.06% (10971/26082)
Line Coverage: 32.33% (92711/286788)
Region Coverage: 31.49% (47556/151024)
Branch Coverage: 27.53% (24084/87488)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c63f7a21d7cb37c244962076cc369b41d3b81377_c63f7a21d7cb37c244962076cc369b41d3b81377/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 191978 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c63f7a21d7cb37c244962076cc369b41d3b81377, data reload: false

query1	1321	938	940	938
query2	6184	1984	1978	1978
query3	10969	4451	4503	4451
query4	60669	35618	23595	23595
query5	5247	612	435	435
query6	316	180	167	167
query7	5011	509	291	291
query8	304	231	213	213
query9	6566	2698	2688	2688
query10	410	315	267	267
query11	15302	15288	15943	15288
query12	167	111	107	107
query13	1028	538	425	425
query14	10804	7332	6781	6781
query15	200	211	197	197
query16	7313	647	499	499
query17	1120	748	608	608
query18	1569	423	328	328
query19	198	194	166	166
query20	117	119	147	119
query21	211	120	102	102
query22	4450	4735	4302	4302
query23	33829	33898	33313	33313
query24	5554	2411	2323	2323
query25	471	467	407	407
query26	630	277	150	150
query27	1678	469	337	337
query28	4156	2534	2484	2484
query29	527	585	449	449
query30	222	191	149	149
query31	922	868	836	836
query32	68	57	60	57
query33	426	363	291	291
query34	745	877	525	525
query35	806	817	798	798
query36	980	1055	945	945
query37	119	98	77	77
query38	4370	4390	4288	4288
query39	1476	1511	1446	1446
query40	228	133	108	108
query41	50	50	49	49
query42	123	105	100	100
query43	515	528	496	496
query44	1365	830	836	830
query45	188	176	178	176
query46	895	1056	647	647
query47	1881	1916	1860	1860
query48	384	406	317	317
query49	695	487	388	388
query50	662	682	393	393
query51	4304	4387	4223	4223
query52	106	110	92	92
query53	233	266	186	186
query54	497	514	427	427
query55	87	78	88	78
query56	266	272	244	244
query57	1262	1214	1164	1164
query58	241	230	228	228
query59	3159	3307	3121	3121
query60	285	272	246	246
query61	120	113	117	113
query62	723	705	658	658
query63	225	196	191	191
query64	1240	1091	682	682
query65	3244	3141	3178	3141
query66	718	400	317	317
query67	16086	15903	15416	15416
query68	5023	826	548	548
query69	491	300	259	259
query70	1195	1159	1054	1054
query71	429	294	268	268
query72	6111	3880	3830	3830
query73	811	769	357	357
query74	10157	9121	8862	8862
query75	3226	3159	2680	2680
query76	3820	1185	783	783
query77	472	371	271	271
query78	10156	10200	9389	9389
query79	1297	878	596	596
query80	1589	534	429	429
query81	596	270	239	239
query82	355	152	126	126
query83	265	167	145	145
query84	283	97	75	75
query85	790	342	299	299
query86	397	320	287	287
query87	4512	4468	4383	4383
query88	3102	2205	2175	2175
query89	472	327	281	281
query90	1493	188	199	188
query91	130	139	105	105
query92	64	55	54	54
query93	1734	883	538	538
query94	679	369	295	295
query95	319	259	256	256
query96	511	615	276	276
query97	2785	2869	2775	2775
query98	218	196	203	196
query99	1256	1389	1248	1248
Total cold run time: 300975 ms
Total hot run time: 191978 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c63f7a21d7cb37c244962076cc369b41d3b81377, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.06	0.03
query3	0.24	0.08	0.07
query4	1.62	0.11	0.10
query5	0.42	0.43	0.40
query6	1.17	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.49	0.52
query10	0.56	0.57	0.54
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.60
query14	2.83	2.77	2.78
query15	0.87	0.83	0.82
query16	0.40	0.41	0.39
query17	1.06	1.05	1.06
query18	0.22	0.21	0.21
query19	1.88	1.76	2.01
query20	0.01	0.02	0.01
query21	15.36	0.92	0.59
query22	0.76	0.79	0.68
query23	15.25	1.51	0.55
query24	2.78	0.87	1.23
query25	0.24	0.12	0.07
query26	0.25	0.15	0.14
query27	0.05	0.06	0.07
query28	13.95	1.03	0.43
query29	12.58	3.96	3.23
query30	0.25	0.09	0.08
query31	2.81	0.62	0.38
query32	3.22	0.55	0.46
query33	2.93	3.11	3.03
query34	16.84	5.10	4.49
query35	4.50	4.55	4.49
query36	0.64	0.48	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.82 s
Total hot run time: 30.53 s

Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants