kie-issues#114: JavaCodeCompletion module fails to compile because of API change #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/vscode-java-code-completion-extension-plugin/vscode-java-code-completion-extension-plugin-core/src/main/java/org/kogito/core/internal/handlers/GetAccessorsHandler.java # pnpm-lock.yaml
# Conflicts: # packages/vscode-java-code-completion-extension-plugin/vscode-java-code-completion-extension-plugin-core/src/main/java/org/kogito/core/internal/handlers/GetAccessorsHandler.java
# Conflicts: # packages/vscode-java-code-completion-extension-plugin/vscode-java-code-completion-extension-plugin-core/src/main/java/org/kogito/core/internal/handlers/GetAccessorsHandler.java
…14-latest # Conflicts: # packages/import-java-classes-component/tests/ImportJavaClasses/ImportJavaClasses.test.tsx
tiagobento
reviewed
Jun 27, 2024
| @@ -1,7 +1,7 @@ | |||
| package com.redhat; | |||
| package org.kie; | |||
There was a problem hiding this comment.
I guess org.apache.kie would be more future-proof...
There was a problem hiding this comment.
Updated @tiagobento
tiagobento
approved these changes
Jun 27, 2024
|
Thanks @yesamer! It's been a long long journey. I respect the patience and the resilience!!! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally closes apache/incubator-kie-issues#114
One year ago the JDT.LS API suddenly changed breaking the Java class "Fetching" mechanism we had in place.
We that change, it was no longer possible to retrieve a class FQCN, which is a required property for the "Fetching" mechanism to properly work.
In the latest release, the API now supports the TypeHierarchy command: given a class name, that command can retrieve the class hierarchy and the first items represent the class itself in FQCN format.
To restore the "Fetching" feature, we can then rely on this new command.
For example, if we use that command on a String type variable, this will return:
The first item contains exactly what we need.
Screen.Recording.2024-06-12.at.10.37.29.mov