Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][EASY] Support to cleanup the spark driver pod with specified cleanup strategy #5731

Closed
2 of 3 tasks
pan3793 opened this issue Nov 20, 2023 · 2 comments
Closed
2 of 3 tasks

[TASK][EASY] Support to cleanup the spark driver pod with specified cleanup strategy #5731

pan3793 opened this issue Nov 20, 2023 · 2 comments
Labels
hacktoberfest

Comments

@pan3793
Copy link
Member

pan3793 commented Nov 20, 2023

What's the level of this task?

EASY

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient expertise on this task, and I volunteer to be a mentor of this task to guide contributors through the task.

Skill requirements

  • Scala Programming Language
  • Spark on K8s concepts

Background and Goals

#5728

Implementation steps

#5728

Additional context

Introduction of 2023 Kyuubi Code Contribution Program
@pan3793
Copy link
Member Author

pan3793 commented Nov 20, 2023

@liaoyt mind leaving some comments here? then I can assign this task to you, and your contributions will be counted in 2023 Kyuubi Code Contribution Program

pan3793 pushed a commit that referenced this issue Nov 20, 2023
@liaoyt @pan3793
[KYUUBI #5731][K8S] Support to cleanup the spark driver pod with spec…
fd4516f 
…ified cleanup strategy

# 🔍 Description

## Describe Your Solution 🔧

A new feature introduced from #5714 supports kyuubi to clean up spark driver pods automatically, but all pod would be clean up without considering app's terminated state.
This PR make user can chose which pods should be delete by setting up a cleanup strategy.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Test locally.

---

# Checklists
## 📝 Author Self Checklist

- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [x] I have performed a self-review
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [x] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes #5728 from liaoyt/master.

Closes #5731

d2cc8cb [yeatsliao] regenerate docs
4caf8b1 [yeatsliao] rename conf 'KUBERNETES_SPARK_DELETE_DRIVER_POD_ON_TERMINATION' to 'KUBERNETES_SPARK_CLEANUP_TERMINATED_DRIVER_POD'
4d970fa [yeatsliao] [K8S] Support to cleanup the spark driver pod with specified clean up strategy

Authored-by: yeatsliao <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit dc03687)
Signed-off-by: Cheng Pan <[email protected]>
@pan3793
Copy link
Member Author

pan3793 commented Nov 20, 2023

This task is completed by @liaoyt via #5728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pan3793