Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Consider publishing the Helm chart to a chart repository #6057

Open
3 of 4 tasks
chgl opened this issue Feb 9, 2024 · 7 comments
Open
3 of 4 tasks

[Improvement] Consider publishing the Helm chart to a chart repository #6057

chgl opened this issue Feb 9, 2024 · 7 comments

Comments

@chgl
Copy link

chgl commented Feb 9, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, deploying via the Helm chart requires downloading the repository and installing from the local directory. Having the chart released to a repository would simplify installation significantly and make it easier to keep the chart up-to-date as a user.

How should we improve?

There is https://github.com/helm/chart-releaser which uses github pages and should be relatively straight-forward to implement.
As of recently, it's also possible to publish Helm charts as OCI artifacts https://helm.sh/docs/topics/registries/. This would allow hosting the chart on ghcr.io or Docker Hub (https://docs.docker.com/docker-hub/oci-artifacts/#push-a-helm-chart).

In my personal helm chart repo, I've been releasing charts using both methods for quite some time: https://github.com/chgl/charts/blob/master/.github/workflows/release.yaml. I'd be happy to contribute a workflow if it makes sense. Things still to figure out:

  1. How should the chart be versioned? - using the above mentioned methods, we could release a new version of the helm chart independent of the main kyuubi release. Everytime the chart is changed, the Chart.yaml version needs to be updated within the PR.
  2. Should we add release notes for the chart itself? - The released charts can be synced to ArtifactHub which provides a nice UI for viewing releases and release notes from annotations: https://artifacthub.io/docs/topics/annotations/helm/

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
Copy link

github-actions bot commented Feb 9, 2024

Hello @chgl,
Thanks for finding the time to report the issue!
We really appreciate the community's efforts to improve Apache Kyuubi.

@chgl chgl changed the title [Improvement] Consider publishing the Helm chart to chart repository [Improvement] Consider publishing the Helm chart to a chart repository Feb 10, 2024
@sudohainguyen
Copy link
Contributor

💯 agree and following

@yaooqinn
Copy link
Member

cc @pan3793 @dnskr @zwangsheng

@pan3793
Copy link
Member

pan3793 commented Feb 20, 2024

I understand that we should do this, but there is a bit tricky issue blocking us to move forward.

TL;DR - how should the user provide Hadoop ecosystem configurations? Embedding large-XML content into YAML is not a good idea in my experience. You can find detailed background from my previous comments, any suggestions are welcome.

@chgl
Copy link
Author

chgl commented Feb 20, 2024

Good points, I've left some comments! Publishing the chart in a repository doesn't prevent someone from still downloading and using the chart locally, though.

@dnskr
Copy link
Contributor

dnskr commented Feb 25, 2024

I understand that we should do this, but there is a bit tricky issue blocking us to move forward.

TL;DR - how should the user provide Hadoop ecosystem configurations? Embedding large-XML content into YAML is not a good idea in my experience. You can find detailed background from my previous comments, any suggestions are welcome.

I'm working on [Improvement] Define general Helm chart configuration approach issue to initiate the discussion and address the problem. I'll create it in a 2-3 days.

@dnskr
Copy link
Contributor

dnskr commented Mar 3, 2024

FYI @chgl
I created the issue #6123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants