what to do about file/src/test/resources/nested-sample.tar ?

[pjfanning]

Used in a unit test.

• remove the file but then need to rewrite the test to create a temp tar file
  • this is not as easy as it sounds - this tar contains multiple tgz files
  • it's not clear if the test needs it to be this complicated
• document what is in our repo and the source release to highlight that this is a test artifact and not a jar
  • ASF bans us from having binaries like jars in our repo and source releases but it doesn't ban all binary files
  • unfortunately, release reviewers might still find the file and still -1 or generally the release

[pjfanning]

@Claudenw there is a test that relies on nested-sample.tar. The tar file has a complicated structure and the test wants this.

I've read https://www.apache.org/legal/release-policy.html and when ASF bans compiled binaries from source releases - nested-sample.tar is not a compiled binary so IMHO this file is ok for inclusion in the source release.

[mdedetrich]

I swear we had a discussion before about this file and it was resolved, no?

[pjfanning]

I can't find any previous discussions about this file. I think we have discussed other binary data files in other repos and I think generally, we've been able to remove them. This one isn't as easy to remove.

[mdedetrich]

Now I remember, it was a discussion about binary files and this tile was mentioned and we had to demonstrate it wasn't a binary file

[Claudenw]

Some of the items I listed can be fixed by adding headers, others I think can be addressed by adding README or other documentation in the directory tree where the problematic files are listed. This is how I would address the sample.tar file; create a document that explains what it is for and perhaps points to the test. q: can you add files to the tar or is the test that picky? i.e. can you add a LICENSE and README file to the tar?

…

On Sat, Jan 20, 2024 at 10:19 PM Matthew de Detrich < ***@***.***> wrote: Now I remember, it was a discussion about binary files and this tile was mentioned and we had to demonstrate it wasn't a binary file — Reply to this email directly, view it on GitHub <#320 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASTVHSF2ZOQVVO67OM4MR3YPQYHDAVCNFSM6AAAAABCDI2Y62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGI3DONBTG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- LinkedIn: http://www.linkedin.com/in/claudewarren

[pjfanning]

Some of the items I listed can be fixed by adding headers, others I think can be addressed by adding README or other documentation in the directory tree where the problematic files are listed. This is how I would address the sample.tar file; create a document that explains what it is for and perhaps points to the test. q: can you add files to the tar or is the test that picky? i.e. can you add a LICENSE and README file to the tar?
…
On Sat, Jan 20, 2024 at 10:19 PM Matthew de Detrich < @.> wrote: Now I remember, it was a discussion about binary files and this tile was mentioned and we had to demonstrate it wasn't a binary file — Reply to this email directly, view it on GitHub <#320 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASTVHSF2ZOQVVO67OM4MR3YPQYHDAVCNFSM6AAAAABCDI2Y62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGI3DONBTG4 . You are receiving this because you were mentioned.Message ID: @.>
-- LinkedIn: http://www.linkedin.com/in/claudewarren

@Claudenw The file was created by Akka team. Why do we need to add license to it? The ASF have no claim to ownership of the file. Akka didn't bother claiming ownership of the file. I will argue this over and over.

[mdedetrich]

@Claudenw My memory is coming back now and I am fairly sure that this file was already reviewed with a fine tooth comb by @justinmclean some time ago and it hasn't change since then.