Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] controlled-failover Optimize example code #23512

Open
1 of 2 tasks
zhuhai1221 opened this issue Oct 24, 2024 · 1 comment
Open
1 of 2 tasks

[Doc] controlled-failover Optimize example code #23512

zhuhai1221 opened this issue Oct 24, 2024 · 1 comment
Assignees
@visxu
Labels
doc-required Your PR changes impact docs and you will update later.

Comments

@zhuhai1221
Copy link

zhuhai1221 commented Oct 24, 2024 •
edited
Loading

Search before asking

  • I searched in the issues and found nothing similar.

What issue do you find in Pulsar docs?

https://pulsar.apache.org/docs/3.0.x/client-libraries-cluster-level-failover/#controlled-failover
There is unnecessary code present
image
image

because org.apache.pulsar.client.impl.ClientBuilderImpl#build already initialize
image

What is your suggestion?

delete provider.initialize(pulsarClient);
image

Any reference?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@zhuhai1221 zhuhai1221 added the doc-required Your PR changes impact docs and you will update later. label Oct 24, 2024
@visxu
Copy link
Contributor

visxu commented Oct 25, 2024

Yes, I checked the doc and source code, I agree the suggestion.
Please assign the issue to me.
@crossoverJie

visxu added a commit to visxu/pulsar-site that referenced this issue Oct 27, 2024
@visxu
Update client-libraries-cluster-level-failover.md
e8adfa7 
Fix issue: apache/pulsar#23512
@visxu visxu mentioned this issue Oct 27, 2024
Merged
2 tasks
visxu added a commit to visxu/pulsar-site that referenced this issue Oct 28, 2024
@visxu
Update client-libraries-cluster-level-failover.md
d89eeed 
Fix issue: apache/pulsar#23512
@visxu visxu mentioned this issue Oct 28, 2024
Merged
2 tasks
nodece pushed a commit to apache/pulsar-site that referenced this issue Oct 28, 2024
@visxu
Update client-libraries-cluster-level-failover.md (#969)
364ec17 
Fix issue: apache/pulsar#23512
nodece pushed a commit to apache/pulsar-site that referenced this issue Oct 28, 2024
@visxu
Update client-libraries-cluster-level-failover.md (#968)
8df3779 
Fix issue: apache/pulsar#23512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@visxu visxu

Labels
doc-required Your PR changes impact docs and you will update later.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@visxu @zhuhai1221